Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support to skip tests based on provided xtf.<product ID>.subId #481

Merged
merged 1 commit into from
Feb 24, 2022

Conversation

fabiobrz
Copy link
Contributor

@fabiobrz fabiobrz commented Feb 22, 2022

This PR is a proposal for adding support for skipping tests based on the xtf.<productId>.subid system property, as per the issue below, since WFLY 27 is not so far away...

Tests added as well, using https://mvnrepository.com/artifact/uk.org.webcompere/system-stubs-jupiter/2.0.1 which seems lightweight enough for use in test scope in order to set properties.

CC @mchoma

Fixes #470

Please make sure your PR meets the following requirements:

  • Pull Request contains a description of the changes
  • Pull Request does not include fixes for multiple issues/topics
  • Code is formatted, imports ordered, code compiles and tests are passing
  • Code is self-descriptive and/or documented

@mnovak1
Copy link
Contributor

mnovak1 commented Feb 23, 2022

@fabiobrz I've just merged #480 which affects the same code. Could you rebase it, please? I'm afraid there will be conflicts in SkipFor class which start to be more complex.

@fabiobrz
Copy link
Contributor Author

@fabiobrz I've just merged #480 which affects the same code. Could you rebase it, please? I'm afraid there will be conflicts in SkipFor class which start to be more complex.

Hi @mnovak1 - thanks for the heads-up. Rebased and adjusted some tests.

Copy link
Contributor

@mnovak1 mnovak1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mnovak1 mnovak1 merged commit 8880da3 into xtf-cz:master Feb 24, 2022
@mnovak1
Copy link
Contributor

mnovak1 commented Feb 24, 2022

Merging, thanks for the PR.

@mchoma
Copy link
Contributor

mchoma commented Feb 24, 2022

In my opinion this can replace name, imageMetadataLabelName, imageMetadataLabelArchitecture as all three options in the end serves to identify image in subId. Of course we need to handle backward compatibility.

So for example where imageMetadataLabelArchitecture was needed now subId can do work as well. in other words seems to me with this feature in place we do not need recent imageMetadataLabelArchitecture option.

@dale-fu
Copy link
Contributor

dale-fu commented Feb 24, 2022

I do still have use for imageMetadataLabelArchitecture in other products as sometimes our team shares the same subId as x86.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend @SkipFor for option unrelated to image, e.g. product subid
5 participants