-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support to skip tests based on provided xtf.<product ID>.subId #481
Conversation
823cffd
to
308effe
Compare
junit5/src/main/java/cz/xtf/junit5/extensions/SkipForCondition.java
Outdated
Show resolved
Hide resolved
308effe
to
fe05cea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Merging, thanks for the PR. |
In my opinion this can replace So for example where |
I do still have use for |
This PR is a proposal for adding support for skipping tests based on the
xtf.<productId>.subid
system property, as per the issue below, since WFLY 27 is not so far away...Tests added as well, using https://mvnrepository.com/artifact/uk.org.webcompere/system-stubs-jupiter/2.0.1 which seems lightweight enough for use in test scope in order to set properties.
CC @mchoma
Fixes #470
Please make sure your PR meets the following requirements: