Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit tests should be added to verify @SkipFor functionality #482

Closed
fabiobrz opened this issue Feb 23, 2022 · 2 comments
Closed

Unit tests should be added to verify @SkipFor functionality #482

fabiobrz opened this issue Feb 23, 2022 · 2 comments
Labels
major

Comments

@fabiobrz
Copy link
Contributor

The @SkipFor annotation is widely used and it has been improved lately, but there's no test to verify the Junit condition that provides the logic to resolve the annotation definition.

This issue tracks the discussion and potential work to add such tests, which could be inspired by one of the latest PRs.
@mnovak1 mnovak1 added the major label Feb 24, 2022
@fabiobrz
Copy link
Contributor Author

Hi @mnovak1 - I was having a quick look at this one and I am wondering whether we actually want more coverage than what is provided already after #481 and related tests have been merged.
IMHO, the current test coverage seems enough for the given annotation, but I might be missing some use cases. Otherwise we could close this as resolved.
WDYT?

@mnovak1
Copy link
Contributor

mnovak1 commented Sep 15, 2022

@fabiobrz hi, you're right. I think it can be closed.

@mnovak1 mnovak1 closed this as completed Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
major
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mnovak1 @fabiobrz