Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure badge + link only points to master branch #46

Merged
merged 1 commit into from
May 24, 2019

Conversation

DiscoStarslayer
Copy link
Contributor

@DiscoStarslayer DiscoStarslayer commented May 24, 2019

Quick change so users download the latest build from master. Prevents people from thinking the project is broken thanks to bad PR's, and ensures only accepted changes get shipped to people as binaries.

Also adds a clearer link to the latest artifact from the master branch.

Closes #45

@mborgerson
Copy link
Member

Thanks!

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@DiscoStarslayer DiscoStarslayer force-pushed the appveyor-badge-to-master branch from d626bf4 to 33ebb91 Compare May 24, 2019 02:41
@mborgerson mborgerson merged commit 00f3bf0 into xqemu:master May 24, 2019
@DiscoStarslayer DiscoStarslayer deleted the appveyor-badge-to-master branch May 24, 2019 02:56
@@ -2,7 +2,8 @@

| Windows Build Status |
| -------------------- |
| [![Build status](https://ci.appveyor.com/api/projects/status/9hb88yawy54b0086?svg=true)](https://ci.appveyor.com/project/xqemu-bot/xqemu-manager) |
| [![Build status](https://ci.appveyor.com/api/projects/status/9hb88yawy54b0086/branch/master?svg=true)](https://ci.appveyor.com/project/xqemu-bot/xqemu-manager?branch=master) |
| [Latest Build](https://ci.appveyor.com/api/projects/xqemu-bot/xqemu-manager/artifacts/xqemu-manager.zip?branch=master) |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally this would have said something about "Download for Windows"; I'm not sure about this second row either.

Or rather, this link should be on our website instead. GitHub is not to be used by Users, so there's no point in distributing end-user binaries here. Also see xqemu/xqemu.com#18

Anyhow, the important thing is that the links point to the right thing.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AppVeyor link in README leads to latest build (including branches / PRs), not master
3 participants