Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppVeyor link in README leads to latest build (including branches / PRs), not master #45

Closed
JayFoxRox opened this issue May 24, 2019 · 1 comment · Fixed by #46 or #61
Closed

Comments

@JayFoxRox
Copy link
Member

It currently points at the opened PR.

It links to:

https://ci.appveyor.com/project/xqemu-bot/xqemu-manager

It should link to:

https://ci.appveyor.com/project/xqemu-bot/xqemu-manager?branch=master


Same issue for the badge; please consult AppVeyor docs how to fix it.

@JayFoxRox
Copy link
Member Author

JayFoxRox commented Oct 22, 2019

The download link isn't actually fixed - this is a security issue.

I think this is a bug in AppVeyor, so I've created a bug report at appveyor/ci#3155


The current situation is the following:

It currently points to https://ci.appveyor.com/api/projects/xqemu-bot/xqemu-manager/artifacts/xqemu-manager.zip?branch=master

That is the same as https://ci.appveyor.com/api/projects/xqemu-bot/xqemu-manager/artifacts/xqemu-manager.zip (without ?branch=master)

Both point at the same build, which is the latest PR, not a build of master.

The link should point to https://ci.appveyor.com/api/projects/xqemu-bot/xqemu-manager/artifacts/xqemu-manager.zip?branch=master&pr=false (note the additional &pr=false)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant