Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Nullable reference type annotations #110

Merged
merged 5 commits into from
Jun 23, 2022
Merged

Add Nullable reference type annotations #110

merged 5 commits into from
Jun 23, 2022

Conversation

udaken
Copy link
Contributor

@udaken udaken commented Jun 23, 2022

This PR has three parts.
The behavior is unchanged throughout.

Applying the Roslyn style code format.

The source code styles were not consistent.
We have added Roslyn Style .editorconfig that has many matching styles.

Modernization.

Addition of NRT annotations.(fix #109 )

Nullabe's policy is as follows

  • All payloads are Nullabe.
  • Nullable if the argument is directly specified as null internally, such as an optional argument.
  • Follow the annotations in .NET6.

Unfortunately, if Nullable is enabled, more than 100 warnings will remain.

@xoofx xoofx merged commit f3b1c7b into xoofx:master Jun 23, 2022
@xoofx
Copy link
Owner

xoofx commented Jun 23, 2022

Thanks!

@udaken udaken deleted the nrt-annotations branch June 23, 2022 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Question: Plans to support NRT?
2 participants