Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Question: Plans to support NRT? #109

Closed
udaken opened this issue Jun 17, 2022 · 2 comments · Fixed by #110
Closed

Question: Plans to support NRT? #109

udaken opened this issue Jun 17, 2022 · 2 comments · Fixed by #110
Labels
enhancement PR Welcome!

Comments

@udaken
Copy link
Contributor

udaken commented Jun 17, 2022

Several changes are required to support Nullable reference types.

  • LangVersion must be 8 or higher.
  • Some annotations need to be incorporated.
  • The code needs to be more modernized.
  • We should add net6.0 to TFM if necessary.

Are these changes acceptable?
@xoofx
Copy link
Owner

xoofx commented Jun 17, 2022

Yes, that will be quite some work (you seem motivated though! 😅 )
but as long as we keep the support for netstandard 2.0 for now, it should be fine.

@udaken
Copy link
Contributor Author

udaken commented Jun 17, 2022

I think very many changes are needed.
Maybe we should start with annotations.

I will keep netstandard2.0 support because it is important.

@udaken udaken mentioned this issue Jun 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement PR Welcome!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Nullable reference type annotations
2 participants
@xoofx @udaken