-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Group Message Kind #217
Group Message Kind #217
Conversation
library/src/main/java/org/xmtp/android/library/Conversations.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updates + tests all look good. One thing I noticed is that for me this PR branch shows LibXMTP Version
empty in the logs for some reason. I'm not sure if maybe bindings were generated in a different way that could cause that. I double tested the version shows up for fine me on main
, but not this branch for some reason.
LibXMTP Version:
Branch:
Date:
Separate from the version not showing up in logs for some reason - it still feels to me that the libxmtp version should be stored somewhere in the project so that we don't have to build and check logs to see what commit hash of libxmtp android is using. Maybe until we automate that, just adding the libxmtp commit hash to description of PRs that update the bindings would be a good failsafe. wdyt?
Also, sorry that the libxmtp version sometimes doesn't show up in code - the |
It might be nice to ensure that |
I copied over the libxmtp txt file. Next time I'm in libxmtp I can take a look at updating the script. 👀 |
Part of xmtp/libxmtp#522
Adds the message kind to returned message. Then filters for them in the SDK so that
GroupMembershipChange
Codecs will only get through the messages list if it also has aMembership_Change
kind.