Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose message kind to platform SDKS so they can spot fake GroupMembershipChanged messages #522

Closed
neekolas opened this issue Feb 20, 2024 · 0 comments
Closed

Expose message kind to platform SDKS so they can spot fake GroupMembershipChanged messages #522

neekolas opened this issue Feb 20, 2024 · 0 comments
Assignees
@nplasterer
Labels
Group Chat - Prod

Comments

@neekolas
Copy link
Contributor

neekolas commented Feb 20, 2024 •
edited
Loading

Valid GroupMembershipChanged messages only get created from inside libxmtp and have a special kind that distinguishes them from regular user-created messages. Today, a malicious client could send a fake GroupMembershipChange messages saying they added/removed someone to a group. We should expose the message kind to integrators so they can spot these fake messages and ignore them.
@neekolas neekolas converted this from a draft issue Feb 20, 2024
@neekolas neekolas changed the title Expose message type to platform SDKS so they can spot fake GroupMembershipChanged messages Expose message kind to platform SDKS so they can spot fake GroupMembershipChanged messages Feb 20, 2024
This was referenced Mar 12, 2024
Closed
Closed
Closed
Closed
@nplasterer nplasterer self-assigned this Apr 5, 2024
This was referenced Apr 5, 2024
Merged
Merged
Merged
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in MLS Work Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nplasterer nplasterer

Labels
Group Chat - Prod
Projects
MLS Work
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@neekolas @nplasterer @bwcDvorak