Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail client instantiation if address does not match stored identity #792

Merged
merged 4 commits into from
May 30, 2024

Conversation

insipx
Copy link
Contributor

@insipx insipx commented May 29, 2024

This is just #776 but on main

closes #763

@insipx insipx marked this pull request as ready for review May 29, 2024 22:51
@insipx insipx requested a review from a team as a code owner May 29, 2024 22:51
Copy link
Contributor

@37ng 37ng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love the tests

Copy link
Contributor

@neekolas neekolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree these tests are great

@insipx insipx merged commit 30af2be into main May 30, 2024
6 checks passed
@insipx insipx deleted the insipx/fail-client-inst-rebase branch May 30, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Client instantiation should fail when the expected account address does not match the stored identity
3 participants