Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client instantiation should fail when the expected account address does not match the stored identity #763

Closed
neekolas opened this issue May 21, 2024 · 0 comments · Fixed by #792
Assignees

Comments

@neekolas
Copy link
Contributor

neekolas commented May 21, 2024

When creating an identity with a strategy of CreateIfNotFound, the SDK should fail to instantiate if the stored identity does not match the address provided.

@neekolas neekolas converted this from a draft issue May 21, 2024
neekolas added a commit that referenced this issue May 21, 2024
## tl;dr

- Gets identity working end to end, with tests (pretty much) all uncommented
- Updates bindings to have all required methods
- Removes a bunch of TODOs in the code

## Follow-ups

There are a few changes I had to make to get everything passing that need some follow-up.
- xmtp/xmtp-node-go#391
- #760
- #761
- #750
- #762
- #763

There are also many places that need better test coverage.
@insipx insipx self-assigned this May 23, 2024
@github-project-automation github-project-automation bot moved this to Done in MLS Work May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
2 participants