Adds test for group members function for non group creator client #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tp/libxmtp into 05-01-create_validated_commit_for_mls
…ub.com:xmtp/libxmtp into 05-01-add_remove_members_using_groupmembership
* gen protos * trait method * scaffold out validation fn, comment next steps in validation fn * validation of inbox ids * no expiration * key package validation * add files * restore proto * remove println * do not break the wasm bindings
## tl;dr - Gets identity working end to end, with tests (pretty much) all uncommented - Updates bindings to have all required methods - Removes a bunch of TODOs in the code ## Follow-ups There are a few changes I had to make to get everything passing that need some follow-up. - xmtp/xmtp-node-go#391 - #760 - #761 - #750 - #762 - #763 There are also many places that need better test coverage.
neekolas
approved these changes
May 22, 2024
|
Once #781 merges this test should start passing |
|
Closed in favor of #794 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.