-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 1.3.14 fails to compile #314
Comments
From the discussion here #284 it seems some code was copy pasted without the necessary context. |
I'm having the same issue too when installing on a Red Hat 8 system with Python 3.9.12. Version 1.3.13 installs just fine
|
Refs: xmlsec/python-xmlsec#314 Signed-off-by: Rick Elrod <[email protected]>
I can confirm that this broke my build as well. ubuntu 22.04 on GHA. |
I can confirm my python project build is broken as well. |
Thanks for the update, xmlsec1 (C library) introduced breaking changes in v1.3.x which made it hard to support old and new version at the same time. I'll note this issue and hopefully we can fix it in the new release. @corneauf @jplrank @fram-sse @shamanthb Can you provide the following information so we can debug easier:
|
xmlsec is an inner dependency used by python3-saml. A newer release of it broke the import. xmlsec/python-xmlsec#314 Signed-off-by: Nizamudeen A <[email protected]>
@mxamin |
@mxamin
|
xmlsec is an inner dependency used by python3-saml. A newer release of it broke the import. xmlsec/python-xmlsec#314 Signed-off-by: Nizamudeen A <[email protected]>
Refs: xmlsec/python-xmlsec#314 Signed-off-by: Rick Elrod <[email protected]>
xmlsec is an inner dependency used by python3-saml. A newer release of it broke the import. xmlsec/python-xmlsec#314 Fixes: https://tracker.ceph.com/issues/65571 Signed-off-by: Nizamudeen A <[email protected]>
@mxamin |
Having same issue in latest installation Python version: (3.11.6 (main, Oct 27 2023, 00:08:24) [GCC 8.5.0 20210514 (Red Hat 8.5.0-18)]) |
xmlsec is an inner dependency used by python3-saml. A newer release of it broke the import. xmlsec/python-xmlsec#314 Fixes: https://tracker.ceph.com/issues/65571 Signed-off-by: Nizamudeen A <[email protected]> (cherry picked from commit ac656f0)
The latest version of python-xmlsec is breaking the mysql8-migrations Github action. See xmlsec/python-xmlsec#314. The recommended course of action is to pin the vesrion of python-xmlsec in the action.
The latest version of python-xmlsec is breaking the mysql8-migrations Github action. See xmlsec/python-xmlsec#314. The recommended course of action is to pin the vesrion of python-xmlsec in the action.
The latest version of python-xmlsec is breaking the mysql8-migrations Github action. See xmlsec/python-xmlsec#314. The recommended course of action is to pin the version of python-xmlsec in the action.
The latest version of python-xmlsec is breaking the mysql-migrations Github action. See xmlsec/python-xmlsec#314. The recommended course of action is to pin the version of python-xmlsec in the action.
The latest version of python-xmlsec is breaking the mysql8-migrations-check Github action. See xmlsec/python-xmlsec#314. The recommended course of action is to pin the version of python-xmlsec in the action.
The latest version of python-xmlsec is breaking the mysql8-migrations Github action. See xmlsec/python-xmlsec#314. The recommended course of action is to pin the version of python-xmlsec in the action.
The latest version of python-xmlsec is breaking the mysql8-check-migrations Github action. See xmlsec/python-xmlsec#314. The recommended course of action is to pin the version of python-xmlsec in the action.
The latest version of python-xmlsec is breaking the mysql8-check-migrations Github action. See xmlsec/python-xmlsec#314. The recommended course of action is to pin the version of python-xmlsec in the action.
For the latest release there are now binary wheels uploaded to pypi for xmlsec. These wheels are compatible with lxml > 5.0. If you are able to install both xmlsec and lxml from wheels you should be able to install the latest version. |
The problem here is that we are not currently compatible with these older libxmlsec1 versions. If you are able to build against a newer version of libxmlsec1 or use the wheel, which is built against the latest version, then the new release should work. |
xmlsec is an inner dependency used by python3-saml. A newer release of it broke the import. xmlsec/python-xmlsec#314 Fixes: https://tracker.ceph.com/issues/65571 Signed-off-by: Nizamudeen A <[email protected]>
xmlsec is an inner dependency used by python3-saml. A newer release of it broke the import. xmlsec/python-xmlsec#314 Fixes: https://tracker.ceph.com/issues/65571 Signed-off-by: Nizamudeen A <[email protected]>
Considering that older libxmlsec1 versions do have security issues, and will likely be deprecated, this may resolve itself on its own |
* fix: create CEA object when enrolling using a license flow * test: verify that allow_enrollment is called_correctly * fix: xmlsec issue xmlsec/python-xmlsec#314
Building these libraries from source requires too much memory, and causes OOMs on a host with 4GB of RAM when still running Zulip. Building from source was enabled in `main` to work around xmlsec/python-xmlsec#320, which does not occur with the xmlsec version in the 8.x branch, as xmlsec/python-xmlsec#314 (incompatibilities with Ubuntu 20.04) causes us to pin xmlsec<1.3.14. As such, we switch back to using prebuilt wheels. The version mismatch from xmlsec/python-xmlsec#320, if real, is not new, so this exposes us to no more risk than before.
Building these libraries from source requires too much memory, and causes OOMs on a host with 4GB of RAM when still running Zulip. Building from source was enabled in `main` to work around xmlsec/python-xmlsec#320, which does not occur with the xmlsec version in the 8.x branch, as xmlsec/python-xmlsec#314 (incompatibilities with Ubuntu 20.04) causes us to pin xmlsec<1.3.14. As such, we switch back to using prebuilt wheels. The version mismatch from xmlsec/python-xmlsec#320, if real, is not new, so this exposes us to no more risk than before.
* fix: create CEA object when enrolling using a license flow * test: verify that allow_enrollment is called_correctly * fix: xmlsec issue xmlsec/python-xmlsec#314 * build: enable CI for pull requests * style: fix some pycodestyle issues
Also happens under RHEL9: OS: |
Can you provide logs of the build error for RHEL9? |
I don't think this is right, don't they both compile against different versions of libxml2? Do we know, specifically, which version of libxml2 is used in the xmlsec wheels? We also use python3-saml which depends on xmlsec, and we were seeing seg faults when using binary wheel versions of xmlsec 1.3.14 and lxml 5.2.2 - see SAML-Toolkits/python3-saml#389 for more details. I tried installing lxml from source which should use the system libxml2 - and that is compatible with xmlsec 1.3.13 but not with 1.3.14. So I tried building xmlsec from source @ 1.3.14 and I run into this same compilation failure. So, no matter what I do, I can't seem to have python3-saml + lxml + xmlsec==1.3.14 on the same system. OS: Linux 6d2916178dc5 6.10.4-linuxkit #1 SMP Wed Oct 2 16:38:00 UTC 2024 aarch64 GNU/Linux |
While installing
xmlsec
1.3.14 we encounter the following error:Looking at the project, the
xmlSecKeyDataFormatEngine
does not seem to be defined anywhere. I've looked the<xmlsec/crypto.h>
include and it does not contain the defined struct either.The text was updated successfully, but these errors were encountered: