Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Planning the next release #315

Open
mxamin opened this issue Apr 18, 2024 · 11 comments
Open

Planning the next release #315

mxamin opened this issue Apr 18, 2024 · 11 comments

Comments

@mxamin
Copy link
Collaborator

mxamin commented Apr 18, 2024

Let's discuss the next release :)

@jonathangreen
@jimjag

@mxamin
Copy link
Collaborator Author

mxamin commented Apr 18, 2024

So far these are the two important issues that need to be handled:
#314
#316

@jonathangreen
Copy link
Contributor

Agreed @mxamin, I think those are the most important as well. I think distributing wheels for Linux #316 will make #314 less important because fewer people will be compiling themselves, but it would still be nice to handle #314 if we can.

@mxamin
Copy link
Collaborator Author

mxamin commented Apr 18, 2024

Agreed @mxamin, I think those are the most important as well. I think distributing wheels for Linux #316 will make #314 less important because fewer people will be compiling themselves, but it would still be nice to handle #314 if we can.

@jonathangreen I agree, I uploaded the linux wheels in the release note. Can you check that for the reported cases using the wheels would actually solve the problem?

@jonathangreen
Copy link
Contributor

It doesn't have to be for next release, the issue has been open for a while, but I think we should look into #239 in the next couple releases.

That issue was written by the maintainer of lxml so the suggestion of how we should be calling the lxml api should be taken seriously.

@jonathangreen
Copy link
Contributor

jonathangreen commented Apr 18, 2024

@jonathangreen I agree, I uploaded the linux wheels in the release note. Can you check that for the reported cases using the wheels would actually solve the problem?

@mxamin I made a small workflow here to test our built wheels for linux, osx and windows against the lxml wheels by running our tests. It shows that the wheels work for lxml >= 5.0. From what I can see in the bug reports that included their lxml version they it seems installing wheels would fix issues for all those reports.

@mxamin
Copy link
Collaborator Author

mxamin commented Apr 18, 2024

Great, then I'll upload the rest of wheels.

Update: It's done

@ryanhiebert
Copy link

If you don’t mind my asking, does this mean that if I install binary versions for the latest version of lxml and this package that I should be good?

@jonathangreen
Copy link
Contributor

@ryanhiebert yes that is correct! That is what I expect based on my testing anyway.

@mxamin
Copy link
Collaborator Author

mxamin commented Apr 19, 2024

FYI, I'm gonna have limited/no access up until May 11th :)

@antoniomika
Copy link

It seems there are inconsistencies now for people that solved an issue previously between lxml and xmlsec by installing lxml without binaries and expecting to use system installed libraries. There are clearly binaries for xmlsec now available on PyPi, which has broken installs. The README mentions needing to install system libraries for Linux, but this is not the case anymore (although, other issues on GitHub mention there are no binary wheels available for xmlsec).

What is the desired case now? Will xmlsec always ship binaries that are compatible with lxml? If not, is the expectation to use --no-binary for both lxml and xmlsec?

Happy for either, I'd just like to make sure this is documented for others!

@jimjag
Copy link
Collaborator

jimjag commented May 6, 2024

This works for me. If desired, I can submit this one to PyPI to help w/ the bus factor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants