moveToViewController does not change the page if created + not visible + animated = false until it become visible #746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…if the moveTo/moveToViewController was requested prior to the viewDidLoad() -> viewDidLayoutSubviews()
…ow (was always first one) if the moveTo/moveToViewController was requested prior to the viewDidLoad() -> viewDidLayoutSubviews()
sorawitt-zz
approved these changes
Oct 20, 2020
sprite2005
approved these changes
Feb 24, 2021
sprite2005
approved these changes
Feb 24, 2021
sprite2005
approved these changes
Feb 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip visibility check (view.window != nil) if non animated viewController change was requested.
User case: a ButtonBarPagerTabStripViewController is not navigationController.topViewController (but was visible so viewDidLoad had been called),
moveToViewController(at: 1, animated: false) was called prior to the screen show (popViewController)
Expected behavior: a controller is shown with selected tab on screen/controller show
Current behavior: a controller change animation starts after the navigation animation is completed.