Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show the PagerTabStripViewController with the selected sub-controller (default tab) #692

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

bivant
Copy link

@bivant bivant commented Mar 22, 2019

Solves the issue and another one

bivant referenced this pull request in Sepicat/XLPagerTabStrip Mar 22, 2019
Copy link

@alexookah alexookah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok

@alexookah
Copy link

alexookah commented May 10, 2019

@xmartlabs please merge this PL into master.

Test:
in viewDidLoad
moveToViewController(at: indexTo, animated: false)
super.viewDidLoad()

@bivant
Copy link
Author

bivant commented May 11, 2019

Hello @alexookah
Is it ok now or I messed it up? My update works as expected if I test with/without it the example app after the merge (critical to call moveToViewCmoveToViewController(at: indexTo, animated: false) before the super.viewDidLoad() )

@alexookah
Copy link

Hello @alexookah
Is it ok now or I messed it up? My update works as expected if I test with/without it the example app after the merge (critical to call moveToViewCmoveToViewController(at: indexTo, animated: false) before the super.viewDidLoad() )

it's ok. just added how to test it so that this get's merged into master.

Copy link

@zhpengkun zhpengkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me.

Copy link

@zhpengkun zhpengkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@zhpengkun
Copy link

@mtnbarreto Is this can be merged? Anyone?

@juanbiberretta
Copy link

Would love to see this merged! :D

@sroymeetup
Copy link

Would be nice to see this get merged! We have an issue in our app that depends on this fix.

@bivant
Copy link
Author

bivant commented Aug 13, 2019

Fix for another user case with sub-controllers switch #746 for anyone interested

Copy link

@ElonPark ElonPark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants