-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update libsnappyjava.so for ppc64le to make it compat with rhel 7 #236
Conversation
@josiahsams Can we add this configuration to Makefile.common instead? Lines 111 to 120 in acaca7f
|
@xerial , Moved the linker flags to Makefile.common. This patch is also required for versions 1.1.7, 1.1.7.1, 1.1.7.2, 1.1.7.3 & master. Thanks. |
Thanks. I'll just release 1.1.7.4 as 1.1.7.x are minor fixes over 1.1.7 |
Hi @xerial - Do you have an intended release date for 1.1.7.4? Thank you -- James |
Hi @xerial, There's a ticket from our side waiting for this fix, any update for the release date of 1.1.7.4? Thanks |
Hello @xerial we hit the issue on ppc64le + RHEL 7 and would like to upgrade to 1.1.7.4. Any update for the new release? |
…rial#236) * update libsnappyjava.so for ppc64le to make it compat with rhel 7 * move linkflag to Makefile.common
@HeartSaVioR Just released snappy-java 1.1.7.4 with this fix. Please try it. |
This PR will address the issue reported in #220 for ppc64le arch.
The GLIBC 2.22 dependency is only due to the following ,
To circumvent this call, we can use linker flags
--no-tls-optimize,--no-tls-get-addr-optimize
to disable it.The .so file attached to this PR is compiled with these flags and relevant changes are made with Makefile and its applicable only for ppcle64 arch.
Ref: https://stackoverflow.com/questions/58958084/disabling-tls-get-addr-opt-for-ppc