Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-31655][BUILD] Upgrade snappy-java to 1.1.7.5 #28472

Closed
wants to merge 2 commits into from

Conversation

AngersZhuuuu
Copy link
Contributor

@AngersZhuuuu AngersZhuuuu commented May 7, 2020

What changes were proposed in this pull request?

snappy-java have release v1.1.7.5, upgrade to latest version.

Fixed in v1.1.7.4

Fixed in v1.1.7.5

  • Fixes java.lang.NoClassDefFoundError: org/xerial/snappy/pool/DefaultPoolFactory in 1.1.7.4

xerial/snappy-java@1.1.7.3...1.1.7.5

v 1.1.7.5 release note:
xerial/snappy-java@edc4ec2

Why are the changes needed?

Fix bug

Does this PR introduce any user-facing change?

No

How was this patch tested?

No need

@SparkQA
Copy link

SparkQA commented May 7, 2020

Test build #122387 has finished for PR 28472 at commit ccb1946.

  • This patch fails build dependency tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented May 7, 2020

Test build #122389 has finished for PR 28472 at commit ff742f5.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@maropu
Copy link
Member

maropu commented May 7, 2020

retest this please

@SparkQA
Copy link

SparkQA commented May 7, 2020

Test build #122393 has finished for PR 28472 at commit ff742f5.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HeartSaVioR
Copy link
Contributor

retest this, please

Copy link
Contributor

@HeartSaVioR HeartSaVioR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@yaooqinn
Copy link
Member

yaooqinn commented May 7, 2020

Test build #122389 has finished for PR 28472 at commit ff742f5.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

cc @gaborgsomogyi, KafkaDelegationTokenSuite seems still flaky for setting up Kerberos

@SparkQA
Copy link

SparkQA commented May 7, 2020

Test build #122396 has finished for PR 28472 at commit ff742f5.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AngersZhuuuu
Copy link
Contributor Author

retest this please

@gaborgsomogyi
Copy link
Contributor

Test build #122389 has finished for PR 28472 at commit ff742f5.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

cc @gaborgsomogyi, KafkaDelegationTokenSuite seems still flaky for setting up Kerberos

I'll check whether it's possible to move setup into the test itself...

@SparkQA
Copy link

SparkQA commented May 7, 2020

Test build #122400 has finished for PR 28472 at commit ff742f5.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HeartSaVioR
Copy link
Contributor

I've taken a look at the failure before - that's a weird situation, as it succeeded to create client/[email protected] principal and keytab, but failed to authenticate.

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. Merged to master for Apache Spark 3.1.0.
Thank you all.

@gaborgsomogyi
Copy link
Contributor

Guys, I've taken a look at the possibilities how to solve the mentioned KafkaDelegationTokenSuite issue and found a new approach. Going to file a jira + PR probably next week...

@nblxa
Copy link

nblxa commented May 11, 2020

Hello. What is necessary to have this fix packported to 2.4.x?

@dongjoon-hyun
Copy link
Member

Hi, @nblxa . Do you hit any snappy issue in Apache Spark 2.4.5?

@nblxa
Copy link

nblxa commented May 11, 2020

Hi @dongjoon-hyun I’m hitting the glibc-2.22 issue with 2.4.3 on RHEL7 on Power due to the snappy-java dependency. I guess the same version of snappy-java is used in 2.4.5?

@HeartSaVioR
Copy link
Contributor

HeartSaVioR commented May 11, 2020

It may be a regression for such architecture (RHEL7 & IBM power) starting from Spark 2.4.0 where snappy-java 1.1.7.1 is being introduced. What I heard is that snappy-java 1.1.2.6 (Spark 2.3.x) doesn't have a reference of glibc-2.22.

I'm not sure the architecture is in official support range, hence can't say whether it's a regression or not. It'd be nice to have this in Spark 3.0.0 at least even it doesn't belong to the official support.

EDIT: forgot to say, I got some report on broken parquet in Spark 2.4.5 + a on same architecture where it was working well with Spark 2.3.x + a.

@maropu
Copy link
Member

maropu commented May 11, 2020

Hi, @nblxa Thanks for the report. The bug should have been fixed in snappy-java v1.1.7.4, but branch-2.4 still uses 1.1.7.3. https://github.com/apache/spark/blob/branch-2.4/pom.xml#L164 .
I think it might be worth bumping up the version. cc: @dongjoon-hyun @holdenk

@AngersZhuuuu
Copy link
Contributor Author

Hi, @nblxa Thanks for the report. The bug should have been fixed in snappy-java v1.1.7.4, but branch-2.4 still uses 1.1.7.3. https://github.com/apache/spark/blob/branch-2.4/pom.xml#L164 .
I think it might be worth bumping up the version. cc: @dongjoon-hyun @holdenk

Raise a pr later.

@dongjoon-hyun
Copy link
Member

Got it. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants