-
Notifications
You must be signed in to change notification settings - Fork 28.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-31655][BUILD] Upgrade snappy-java to 1.1.7.5 #28472
Conversation
Test build #122387 has finished for PR 28472 at commit
|
Test build #122389 has finished for PR 28472 at commit
|
retest this please |
Test build #122393 has finished for PR 28472 at commit
|
retest this, please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
cc @gaborgsomogyi, KafkaDelegationTokenSuite seems still flaky for setting up Kerberos |
Test build #122396 has finished for PR 28472 at commit
|
retest this please |
I'll check whether it's possible to move setup into the test itself... |
Test build #122400 has finished for PR 28472 at commit
|
I've taken a look at the failure before - that's a weird situation, as it succeeded to create |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM. Merged to master for Apache Spark 3.1.0.
Thank you all.
Guys, I've taken a look at the possibilities how to solve the mentioned |
Hello. What is necessary to have this fix packported to 2.4.x? |
Hi, @nblxa . Do you hit any snappy issue in Apache Spark 2.4.5? |
Hi @dongjoon-hyun I’m hitting the glibc-2.22 issue with 2.4.3 on RHEL7 on Power due to the snappy-java dependency. I guess the same version of snappy-java is used in 2.4.5? |
It may be a regression for such architecture (RHEL7 & IBM power) starting from Spark 2.4.0 where snappy-java 1.1.7.1 is being introduced. What I heard is that snappy-java 1.1.2.6 (Spark 2.3.x) doesn't have a reference of glibc-2.22. I'm not sure the architecture is in official support range, hence can't say whether it's a regression or not. It'd be nice to have this in Spark 3.0.0 at least even it doesn't belong to the official support. EDIT: forgot to say, I got some report on broken parquet in Spark 2.4.5 + a on same architecture where it was working well with Spark 2.3.x + a. |
Hi, @nblxa Thanks for the report. The bug should have been fixed in |
Raise a pr later. |
Got it. Thanks. |
What changes were proposed in this pull request?
snappy-java have release v1.1.7.5, upgrade to latest version.
Fixed in v1.1.7.4
Fixed in v1.1.7.5
xerial/snappy-java@1.1.7.3...1.1.7.5
v 1.1.7.5 release note:
xerial/snappy-java@edc4ec2
Why are the changes needed?
Fix bug
Does this PR introduce any user-facing change?
No
How was this patch tested?
No need