Issue 455/add stagenet support #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like xchain-binance has a |
polaris-9r
force-pushed
the
issue-455/add-stagenet-support
branch
2 times, most recently
from
06d6e7d to
0680ae7
Compare
…lient by using testnet env values
polaris-9r
changed the title
…ChainClient to indicate stagenet and using real assets
veado
requested changes
Dec 29, 2021
veado
reviewed
Dec 29, 2021
veado
reviewed
Dec 29, 2021
…e mainnet thornode api base to point to thornode.ninerealms.com
…s for getPrefix and validateAddress for thorchain
|
Requested changes have been made @veado |
veado
approved these changes
Dec 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new stagenet value for the
Networkenum and stagenet support in theBaseXChainClientclass inxchain-client, to be used in thexchain-thorchainfor stagenet support. Originally these changes were only limited to thexchain-thorchainpackage, but because this is a breaking change forxchain-client, all other packages dependent on theNetworkenum have been updated to handle a stagenet case by resolving to the values for their respective mainnet configuration.Notes
With respect to
xchain-binance, there is a type dependency from the@binance-chainJS SDK in thechooseNetworkfunction that enforces onlymainnetandtestnetvalues that requires a workaround until the SDK supports a stagenet value.To-dos