-
Notifications
You must be signed in to change notification settings - Fork 50
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DRAFT LGTM.
Just two (small) things so far:
(1) Pls update helper toClientNetwork
(2) In case you want to change color of network label in header, here is the place to do
asgardex-electron/src/renderer/components/header/HeaderComponent.styles.ts
Lines 85 to 94 in eb574a5
color: ${({ network }) => { | |
switch (network) { | |
case 'mainnet': | |
return palette('primary', 0) | |
case 'testnet': | |
return palette('warning', 0) | |
default: | |
return palette('text', 2) | |
} | |
}}; |
… network selection text
…PendingAssetsWarning component, add stagenet thornode handling, add stagenet to isNetwork utils check
@veado Wanted your perspective on one last part of this PR. So as you can see from the screenshots in my first post, the pool values are different between chaosnet and stagenet because they are hitting the mainnet vs stagenet versions of midgard. I can confirm though that in the wallet tab that the non-TC chain wallet addresses are the same values. Question is:
|
@@ -235,11 +239,13 @@ export const ASGARDEX_SWAP_IDENTIFIER = 999 | |||
|
|||
export const RECOVERY_TOOL_URL: Record<Network, string> = { | |||
testnet: 'https://testnet.thorswap.finance/pending', | |||
stagenet: 'https://stagenet.thorswap.finance/pending', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@veado Wanted confirmation as to whether this should be stagenet specific or the mainnet value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems https://stagenet.thorswap.finance/pending is accessible, so let's use it.
mainnet: 'https://app.thorswap.finance/pending' | ||
} | ||
|
||
export const ASYM_DEPOSIT_TOOL_URL: Record<Network, string> = { | ||
testnet: 'https://testnet.thorswap.finance/', | ||
stagenet: 'https://stagenet.thorswap.finance/', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@veado See above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, lgtm
.env changes are optional
…com to url whitelist
Wallet -> Assets -> BTC
Same for chaosnet, It might be an issue with haskoin api. Can we use |
I would keep it separate (stagenet -> stagenet pools only, mainnet -> mainnet pools only - but no hybrid) to handle differences more easily. Since we are using different RUNE ( |
It seems Example: Three options:
|
Yeah, given this lack of functionality, I think I'd personally want to err on the side of not showing transactions at all in case of stagenet, in line with what we were saying that stagenet should only see stagenet, mainnet should only see mainnet, etc. I'll put some gatekeeping for now and we can figure out when viewblock is going to support stagenet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
300fce1 fixes xchain-* related issues. Agree, urls for viewblock are not a blocker - the viewblock team will provide stagenet soon (see Discord message https://discord.com/channels/838986635756044328/846612413477945384/928043598367326228)
Happy to merge now, thanks again for your great work @polaris-9r!
Description
This ticket enables a user to switch to stagenet for THORChain, but leaves all other chains as chaosnet. This PR includes the following major changes
@xchainjs
libraries to new breaking change versions that add stagenet functionality for the base client classStagenet
network, with coloring in redisEnabledLedger
check.Notes
I was able to verify that we were able to create an
sthor
prefixed wallet addresses via a dev version of the electron app, and transfersthor
RUNE into that account.Screenshots of new FE styling:
Chaosnet
Stagenet
NOTE: Leaving this in draft form at the moment since this is dependent on landing a change in xchainjs to add stagenet environment config: xchainjs/xchainjs-lib#456TODO:Land xchainjs changes to add stagenetUncomment changes that reference Network.StagenetRun through CI/CD to see if there are any other issues#1987