Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[googletest] Version bump v1.13 #1173

Merged
merged 2 commits into from
Mar 3, 2023
Merged

[googletest] Version bump v1.13 #1173

merged 2 commits into from
Mar 3, 2023

Conversation

CastagnaIT
Copy link
Collaborator

@CastagnaIT CastagnaIT commented Feb 27, 2023

Description

Version bump v1.13
to fixes apple compiler issues

UWP build raise in_death_test_child_process: undeclared identifier error
its a regression bug of v1.13, so i had to add a patch taken from google/googletest#4164

Motivation and context

superseeds #1106

How has this been tested?

CI builds green status
Run tests on VS for Windows

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • I have read the Contributing document
  • My code follows the Code Guidelines of this project
  • My change requires a change to the Wiki documentation
  • I have updated the documentation accordingly

@CastagnaIT CastagnaIT added Type: Improvement non-breaking change which improves existing functionality Component: Depends v21 Omega labels Feb 27, 2023
@CastagnaIT CastagnaIT requested a review from glennguy March 1, 2023 10:07
@glennguy glennguy merged commit 7056a28 into xbmc:Omega Mar 3, 2023
@tmm1
Copy link
Contributor

tmm1 commented Mar 9, 2023

can this be backported?

@CastagnaIT CastagnaIT deleted the gtest_bump branch March 28, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport: Done Component: Depends Type: Improvement non-breaking change which improves existing functionality v21 Omega
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants