Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[googletest] bump from v1.10 to v1.13 to fix compile issues #1106

Closed
wants to merge 2 commits into from

Conversation

tmm1
Copy link
Contributor

@tmm1 tmm1 commented Jan 27, 2023

fixes compile issues on my system:

inputstream.adaptive/build/build/googletest/src/googletest/googlemock/include/gmock/gmock-matchers.h:891:3: error: definition of implicit copy constructor for 'EndsWithMatcher<std::wstring>' is deprecated because it has a user-declared copy assignment operator [-Werror,-Wdeprecated-copy]
  GTEST_DISALLOW_ASSIGN_(EndsWithMatcher);
  ^

which is a known issue fixed here: google/googletest#2815

my compiler details:

Apple clang version 14.0.0 (clang-1400.0.29.202)
Target: arm64-apple-darwin22.2.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin

@CastagnaIT CastagnaIT added Type: Fix non-breaking change which fixes an issue v20 Nexus Component: Depends labels Jan 27, 2023
@@ -1 +1 @@
googletest http://mirrors.kodi.tv/build-deps/sources/googletest-1.10.0.tar.gz
googletest https://github.com/google/googletest/archive/refs/tags/v1.13.0.tar.gz
Copy link
Contributor

@fuzzard fuzzard Jan 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ive thrown this up on mirrors. Should start being available shortly

https://mirrors.kodi.tv/build-deps/sources/googletest-1.13.0.tar.gz

@CastagnaIT
Copy link
Collaborator

CastagnaIT commented Jan 28, 2023

i think this version bring some problem when compiling on windows UWP systems
this is a log example:
https://dev.azure.com/teamkodi/c0b097aa-5a38-4262-8355-1f4897fea12d/_apis/build/builds/12342/logs/68
but i am no expert on builds
ofc need to be fixed

@CastagnaIT
Copy link
Collaborator

is possible we need to add new GTEST_HAS_FILE_SYSTEM flag?
see: google/googletest@b0846aa

@CastagnaIT
Copy link
Collaborator

Are you planning to investigate to finish the PR in the near future?
just to know if we have to take it over,
in which case i close it and i will add it to the roadmap to be done when we have time

@CastagnaIT
Copy link
Collaborator

no answers and since cannot be merged as is
i close the PR and i add it to roadmap
if one day you want continue the development we can always reopen it

@CastagnaIT CastagnaIT closed this Feb 9, 2023
@CastagnaIT CastagnaIT mentioned this pull request Feb 27, 2023
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Depends Type: Fix non-breaking change which fixes an issue v20 Nexus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants