add reverse dependencies check #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That should suffice for now I think.cant think of anything else |
Rechi
force-pushed
the
check/reverseDependencies
branch
2 times, most recently
from
6e1af68 to
3d7f0b9
Compare
|
Shouldn't you add license header for the new files? |
Rechi
force-pushed
the
check/reverseDependencies
branch
from
3d7f0b9 to
23b176f
Compare
Rechi
force-pushed
the
check/reverseDependencies
branch
2 times, most recently
from
f60e54d to
e1fc0d2
Compare
enen92
reviewed
Nov 16, 2018
| super(Repository, self).__init__() | ||
| self.version = version | ||
| self.path = path | ||
| gz_file = requests.get(path, timeout=(10, 10)).content |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
enen92
approved these changes
Nov 16, 2018
Rechi
force-pushed
the
check/reverseDependencies
branch
from
e1fc0d2 to
03a7aba
Compare
Rechi
force-pushed
the
check/reverseDependencies
branch
from
03a7aba to
099d385
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #124
@MartijnKaijser is it correct to only warn for add-ons which have
script.module.*as id?