Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for orphaned add-on #124

Closed
MartijnKaijser opened this issue Oct 13, 2018 · 4 comments · Fixed by #142
Closed

Add check for orphaned add-on #124

MartijnKaijser opened this issue Oct 13, 2018 · 4 comments · Fixed by #142

Comments

@MartijnKaijser
Copy link
Member

Over time some add-ons might become broken/obsolete and will be removed. Some have a certain helper add-on which we then also forget to remove. Would be nice if we could detect this in some way if there are any. This can be done in the general scan on each branch and doesn't need to bother the regular submission report.

@mzfr
Copy link
Contributor

mzfr commented Oct 15, 2018

What do you mean by helper add-on? Does it mean addons present in the require section of the addon.xml? Can you please provide an example of an addon

@MartijnKaijser
Copy link
Member Author

Indeed one that is marked as required by other add-ons.
Almost all module scripts are helper add-on as they do not function on their own but are called by some other script/plugin

@mzfr
Copy link
Contributor

mzfr commented Oct 15, 2018

So the check should be like: if the addon is broken then just point out it's require addon.
Is it possible that the same helper will be there for two different add-ons? if yes then I don't think so we will need this.

@MartijnKaijser
Copy link
Member Author

MartijnKaijser commented Oct 15, 2018

yes a module can be used by multiple addons however in the end it might not used at all anymore.
So any .module. needs to be added as dependency at least once for any addon.

Edit: yes i am really sure we need this (handled addon repo since 2011 ;) )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants