Skip to content

Commit

Permalink
Remove special handling of stackSave/stackRestore/stackAlloc (emscrip…
Browse files Browse the repository at this point in the history
…ten-core#17399)

There is no different between how these symbols are handled under the
standard an minimal runtime (unlike the other symbols that are added
separately there).

I'm working changes to remove all the different in the library vs
runtime split that exist between minimal runtime and regular runtime.
For most symbols this means moving them to JS library functions but for
these three they are already handled the same in both runtimes.
  • Loading branch information
sbc100 authored and arbiny committed Jul 22, 2022
1 parent 90e9b49 commit 86ab79c
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions src/modules.js
Original file line number Diff line number Diff line change
Expand Up @@ -446,6 +446,11 @@ function exportRuntime() {
'abort',
'keepRuntimeAlive',
'wasmMemory',
// These last three are actually native wasm functions these days but we
// allow exporting them via EXPORTED_RUNTIME_METHODS for backwards compat.
'stackSave',
'stackRestore',
'stackAlloc',
];

if (USE_PTHREADS && ALLOW_MEMORY_GROWTH) {
Expand Down Expand Up @@ -473,9 +478,6 @@ function exportRuntime() {
runtimeElements = runtimeElements.concat([
'run',
'warnOnce',
'stackSave',
'stackRestore',
'stackAlloc',
'AsciiToString',
'stringToAscii',
'UTF16ToString',
Expand Down

0 comments on commit 86ab79c

Please sign in to comment.