Remove special handling of stackSave/stackRestore/stackAlloc #17399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is not different between how these symbols are handled under the standard an minimal runtime (unlike the other symbols that are added separately there). I'm working changes to remove all the different in the library vs runtime split that exist between minimal runtime and regular runtime. For most symbols this means moving them to JS library functions but for these three they are already handled the same in both runtimes.
kripken
approved these changes
Jul 8, 2022
|
In the description, |
xbcnn
pushed a commit
to xbcnn/emscripten
that referenced
this pull request
Jul 22, 2022
…ten-core#17399) There is no different between how these symbols are handled under the standard an minimal runtime (unlike the other symbols that are added separately there). I'm working changes to remove all the different in the library vs runtime split that exist between minimal runtime and regular runtime. For most symbols this means moving them to JS library functions but for these three they are already handled the same in both runtimes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no different between how these symbols are handled under the
standard an minimal runtime (unlike the other symbols that are added
separately there).
I'm working changes to remove all the different in the library vs
runtime split that exist between minimal runtime and regular runtime.
For most symbols this means moving them to JS library functions but for
these three they are already handled the same in both runtimes.