Update zha args for ZigBee 3.0 firmware #46
Conversation
With ZB 3.0 firmware the long press args changes for up and down for E1810/E1524 This duplicates the events to ensure both old and new firmware works as expected.
|
This should fix #45 |
Added in E1810 toggle hold (3 seconds) events for lights --> ON_FULL_BRIGHTNESS Not sure what to do with the zha extra long press (3.5 seconds) Only zha supports it as "press_2_0_0" When paired directly to ikea bulbs it resets the color temp to their default 2700K/warm white. Is it possible to implement a default color temp config to use?
| @@ -13,6 +13,7 @@ class E1810Controller(LightController): | |||
| def get_z2m_actions_mapping(self): | |||
| return { | |||
| "toggle": Light.TOGGLE, | |||
| "toggle_hold": Light.ON_FULL_BRIGHTNESS, | |||
There was a problem hiding this comment.
When holding the button. It sends hold straight away and after 3 seconds it sends toogle_hold. So this means that if the light is on, you will experience that ehe light will turn off when holding the button and after 3 seconds it will turn the light again to full brightness. For this reason, I did not add this behaviour to the default controller, it is rather confusing.
| "toggle_hold": Light.ON_FULL_BRIGHTNESS, |
| @@ -30,6 +31,7 @@ def get_z2m_actions_mapping(self): | |||
| def get_deconz_actions_mapping(self): | |||
| return { | |||
| 1002: Light.TOGGLE, | |||
| 1001: Light.ON_FULL_BRIGHTNESS, | |||
There was a problem hiding this comment.
I guess this is the event when holding, but does the 1002 fires when holding? Same as z2m?
| "move_to_level_with_on_off_254_0": Light.ON_FULL_BRIGHTNESS, | ||
| ### "press_2_0_0": SET A DEFULT COLOR TEMP? |
There was a problem hiding this comment.
You said the following:
A long press generates:
toggle right away, followed by release then move_to_level_with_on_off_254_0 then press_2_0_0 all in quick succession after the center button is held for 3 seconds.
We have the same problem that I described before, the "toggle" action fires first, so it is not useful to use the hold center button.
| "move_to_level_with_on_off_254_0": Light.ON_FULL_BRIGHTNESS, | |
| ### "press_2_0_0": SET A DEFULT COLOR TEMP? |
|
I will merge this PR and I will do the change from here as discussed in #45 |
@xaviml - with new firmware version the args have changed for these remotes.
This PR duplicates the hold events to capture both version of the args
The zha developers may find a way to keep them consistent in the future, but it might be a bit before that happens (HASS 107) so this will patch the user experience until this happens.
If removed in the future due to changes on the quirk end, can remove these changes with a breaking change notice for those who set up custom mapping.