-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Issues with E1810 Controller #45
Comments
I don't think error this scheduler error anything to do with controllerx. Scheduler errors started showing up in my appdaemon log as well all of a sudden. Start up appdaemon with my controllers commented out, still getting the error. However, controllers function fine. Going to do some digging.... |
Turns out there is something strange going on with the quirk. The mappings for hold up and hold down have different args than previously all of a sudden. Hold up now generates I don't see a change in the device handlers for this on the upstream repo so not sure what's going on yet.... |
@jrbenito - I just confirmed it's only because of the new args. Still need to figure out why they've changed to see if we need to change them in ControllerX. On the zha-device-handlers repo there are a couple of versions of quirks for the 5-button remote but none of them have different args. kitchen1_controller:
module: controllerx
class: E1810Controller
controller: cc:cc:cc:xx:xx:xx
integration: zha
smooth_power_on: true
light: light.kitchen_master
mapping:
"toggle": "toggle"
"step_with_on_off_0_43_5": "click_brightness_up"
"step_1_43_5": "click_brightness_down"
"press_257_13_0": "click_color_down"
"press_257_13_0": "click_color_down"
"press_256_13_0": "click_color_down"
"move_with_on_off_0_84": "hold_brightness_up"
"move_1_84": "hold_brightness_down"
"hold_3329_0": "hold_color_down"
"hold_3328_0": "hold_color_up"
"stop": "release"
"release": "release" |
Also, while I was looking at this, I realized we don't have a mapping for a long hold of the centre button. On ikea bulbs it sets to them to their default color temp and to on. @xaviml is that implemented anywhere? Perhaps could implement a |
@jrbenito did you turn on ota_update recently? |
a fresh pull of the dev tag of appdaemon has resolved this for me. The issue discussed here |
Yes, all my devices were updated by OTA. So the firmware upgrade did broke things. Thanks for all of information you gathered, I am learning a lot here. |
Btw, is there a easy way to get firwmare version from the IKEA devices? |
@sreknob using z2m, there's just one 'toggle_hold' trown after 3 seconds. |
@jrbenito yes, super easy to get the firmware version in zha @htvekov I will update the PR with the long hold for zha. Not sure how to handle setting to a specific/default color temperature value. |
Hi guys, I reviewed @sreknob's PR and the problem with the Thanks for the PR and the debug hunting, I would have never guessed it was the firmware. I will merge the PR after the request changes. |
@xaviml - glad to help out. Any thoughts about having a default colour temp/xy_color default that is configurable? |
My two cents... As the pause is EXTREMELY long until hold event is fired , I agree with @sreknob that a default color temp reset could be a useful addition of events for an E1810. Wasn't even aware that this was a default implementation of hold on IKEA hub 🤔😁 But should only be implemented when toggle is held from off position. Otherwise, from on position, lights would first turn off and after 3 seconds turn on again reset to default colours. |
Hi @sreknob, Thanks for the detailed explanation. I understand now. So the default behaviour is already this? So if the light is on and you hold, it will turn the light off and if you wait 3 seconds, it will turn the light in full brightness and default temp? I am not sure what you mean with "default colour temp/xy_color". Do you mean a default defined by user or hardcoded? If it's defined by user, you can already do that with custom controllers. I will accept your PR as it is. However, I have to options:
Let me guys know what you think. Thank you :) |
Hi' Xavi/Blake. As the wait is so extremely long for hold to be fired, I don't think any user would experience problems in daily use with either of the options. But my personal opinion is that I would prefér function was only called from lights off 😉 Either way, it's yet another usefull addition to ControllerX. Which rapidly has gone from 'basic light controller' to one of the most versatile and helpful additions build for HA 🚀🚀😎👍 |
Hey Guys - Thanks for the additional discussion! So yes, the default behaviour of the controller is kind of strange, It doesn't care what the state of the light is before the hold. If the lights are on, it tuns them off at the start of the hold, just the standard toggle command. Then after the long hold, it turns all the lights on to full brightness and 2700K color temp (for color and tunable bulbs). I'm pretty sure the reason that it was designed this way is that these issues commands to an entire zigbee group. When you have no other way of controlling the lights and some get out of sync, then you could be left with bulbs of different color temps and no number of "steps" will get them back where you want them. This way, the long press first toggles everything like standard (and yes, sometimes you do stand there in the dark for a few seconds) then everything comes back on at full brightness and 2700K/warm white. From there, you can then adjust as needed. You can see the ikea video about it here to illustrate what I'm talking about. What they don't have shown is that it also fixes the brightness out of sync as well (guess there were too many combinations to make videos about them all!) It's from their support section of their website. I think it should do the default implementation and not get too fancy. Again, the use case is kind of limited by the nature of timing. It's pretty unlikely that the lights get out of sync but it's a great solution when they do. (I've never had it happen at home - just my 6 lights at my office which are just directly paired). |
Perfect, I will add it no matter if the light is on or off. It will be a nice feature to have to leave the light to a default setting, you are right. However, the way ControllerX is done, it syncs every time you long-press or press, because it takes the values from the first light of the group and changes the attributes according to that light, this is why you may not have experienced a desynchronization. I will create this and let you know once it is done to test. Thank you for everything :) |
I did not know this -- this is so cool! Thanks @xaviml - you're the best! 💯 |
Hi' Xavi. That could be the reason my Hue light groups behaves irregular using ControllerX dimming up/down then ? 🤔 Lights don't follow each other exactly when dimming. And hold button only dims partly up/down and then stops. If I create a manual light group in HA, dimming behaviour is perfect (understandable when I now know why 😊). Only on/off is not exactly syncronized - expected with separate calls for each entity. And it's impossible for users with lights on Hue bridge and sensors on z2m to create and use z2m 'special' groups, as the lights are not exposed to z2m. Does the code distinguish between a single entity and Hue light groups (checks |
Hi guys, I just released I tested it with E1810 controller with z2m integration and it does what is expected, like the video you sent. You guys can let me know if it also works for deCONZ and ZHA. |
Hi @htvekov , Regarding your issue, ControllerX does not support Light Group, although depending on the setup it will work. The safest way to set up a group of lights is with Group, this way ControllerX knows is a group of lights and follows the attributes from the first light on the group (the master light). This is how the group of lights are treated on ControllerX for the moment, so I cover all the cases since it relies on HA services. I do not intend to change this for specific devices. This means that if you use |
Awesome Xavi - will test tonight when I get home! |
Hi' Xavi. Just tested the new
|
I see, I will fix that up! @htvekov |
Okay, v2.4.0b2 released, you can check again. If color_temp and xy_color are not supported, then it just applies the changes to the brightness. |
Ok, Xavi. Tested v2.40b2
Still throws an error after 2020-03-03 19:13:10.153509 WARNING office_controller: ------------------------------------------------------------ |
@sreknob & @xaviml From on position: Still only sets brightness to 100% but color remains unchanged So with transition: 0 it works from off position for Ikea color bulb (on Hue bridge) |
The transition issue we discuss in this thread, is only a problem with a specific ControllerX feature in beta test. In general, there are issues with simultaneous brightness/color commands on Ikea bulbs, but nothing that will prevent any ControllerX configuration to work. |
well, for some reason, (i trust is missconfig), mine is not working no matter what change I make. |
@branitelj91 - indeed likely a configuration issue. |
Hi @branitelj91 |
Interestingly enough, I knew this, but I forgot about it. I know you guys tried with transition 0, but I will remove the transition attribute from the request when calling from sync to see if that fixes it. |
I just released Remember to click Thank you guys! |
Hi' Xavi Just tested latest beta. Same setup as previous:
Just tested an additional bulb as well. And finally a Philips Hue White And Color Ambiance E27 bulb. |
Hi @xaviml , I will try my best to confirm today night. Sorry for delay, I am having busy days at work this week. Today will be! (btw, here is 9AM, so in about 12 hours I come back with an answer :D) |
Hi' again, Xavi. Just tested direct service calls from HA But if I DON'T state the transition: 0 parameter, then color will change but brightness will NOT change !!! Sometimes i can trigger brightness change after several repeated identical calls. And changes to color/brightness are NOT without transition ? Looks like transition 300-400ms to me. But transition attribute shouldn't be added by the Hue bridge, as it doesn't support transition settings for other bulbs than their own. Assume that the Ikea bulbs have a 'default' transition period if not otherwise stated in calls ? Can someone with Ikea bulbs on z2m network confirm this, please ? Conclusion: Transition attribute (with 0 value) can't be omitted, but HAS to be included in call ! Really, really strange that Ikea hasn't fixed this obvious bug in their zigbee fw ?? OK. Extensive 'test night' 😉🌚⭐ With Ikea bulb on z2m network, latest beta One final note. With Ikea bulb now on z2m network, I can confirm that bulb indeed accepts both brightness AND color change in same call. But implementation of transition is somewhat 'left hand' work. If both brightness AND color is in call, then brightness change is instant and only color transitions !?!? If only brightness OR color is in call, then both can do transition. Conclusion: Ikea bulbs can apparently only handle one transition at a time and color transition has highest priority ! Pheeww ! 😅😊 Ciao ! |
While I have the bulb on the z2m network, I took advantage of the newly introduced OTA update function of Ikea bulbs via zigbee2mqtt. I updated from fw 1.3.002 to fw 1.3.009 on my Ikea color bulb. This Ikea bulb issue with both bulb fw bug- and the Hue bridge issues is not easy to navigate in... Night everyone and a pleasant EVENING to you @jrbenito 😉😁
|
Organizing: My E1810 controller now can:
Thanks guys, WAF is now reestablished and you saved my day. cheers |
Hi @htvekov. Sorry, but are you saying that if transition is added with 0, it works as expected? So from on will put the light full brightness and color in 2700K and the same from off?
Perfect, thank you @jrbenito !! |
Hi' Xavi. I'll try to recap from memory (I'm at work 😁) I only tested latest beta without any transition settings in config. With Ikea colour bulb on z2m and transition removed from app settings:
With Ikea colour bulb on Hue bridge and transition removed from app settings.:
So there's issues with I'll expect it to work on Hue bridge if you send But I really can't figure out why beta doesn't work correctly from Is the above explanation understandable at all, Xavi ?? 🤔🙄 |
Hi' Xavi. Just repeated the tests on both Hue bridge and z2m network with Same results as earlier test. No difference at all. Ciao ! |
Hi' Xavi. Latest beta v2.4.0b3 z2m logs. Z2m log of
Z2m log of
The set I belive that transition: 0 attribute is needed for Ikea bulb to function with in betav2.4.0b2 transition is included in call (defaults to 0,3 sec. i believe) and default can be changed via app settings. Here the Ikea bulb gets all three calls:
Ciao ! |
I just tried this out with a few other scenarios using the current beta, including an osram bulb on zha and a hue bulb on hue hub. No app setting of transition. The behaviour is the same. Sync works when called with the bulb in an ON state but does not work when called with the bulb in the OFF state. This turns the bulb on to full brightness with the color unchanged. calls from HA, regardless of the state of the bulb work:
|
Hi all, I have been debugging but I did not seem to find a solution that works well when the light is on and off and also for color temperature and xy color. For this reason, I will keep the I have tried to change the homeassistant/turn_on service to light/turn_on service and the problem still persisted in my end with a color bulb. I also tried sending Thank you all for testing this out and help me to find a solution to this! |
Hi' Xavi. I don't know if it's possible at all, to find a solution that covers all bulb types on all zigbee integration solutions ? Anyway, just wanted to share my 'workaround' solution. Using latest beta v2.4.0b3 I've made some controllerX apps to 'emulate' Tested:
Thanks for all your hard work, Xavi ! 👍👍😎 |
Did I understand correctly, when you say that Really strange then... |
Wow! That is an extensive example of how to configure ControllerX in advance mode. I have to say you control better the ControllerX configuration than me 🤣 However, from now on Thank you @htvekov :) |
I also created a bug for the sync problem, so I can close this issue (#54) |
thanks @xaviml |
Hi' Xavi I'll comment in issue #54 :-) |
Bug report
Smoth power on does not work with Zigpy and E1810.
Brightness long press does not increase/decrease brightness with E1810
Both features works with E1473 on the same lighs
Sorry for report this again, I finally had sometime to try various combinations and try sort this out.
Description
This is same as #24 but now, I have more information.
Smooth power on does not work with E1810 controller. I have two of them, assigned to two different set of lights but both do not work with smooth power on.
Behavior:
all single press works (toggle lighs, bright up/down and change color temp).
All long press does not work.
With controller E1743:
Additional information
Notice that
light.kitchen_master
is a light group. We already talked about thatlight.group
might not work, but it works with E1473 controller. I also changed the above to a single light device and group of lights (instead light group). All configurations presented same behavior.zha
withbellows
for radio interfaceAppDaemon app configuration
Logs
This log started to happen today, don't think it is related to the problem.
There are no logs from the ZHA when long presses are done with lights off.
With lights on, ZHA emits:
One at the start of the long press, another on the release. Nothing more (I set log leve for debug).
Additional Context
Thanks for your good work. If you need any other information, I will gladly provide.
Best regards.
The text was updated successfully, but these errors were encountered: