[BUG] Smooth Power On causing issues #24
Comments
|
Have you restart AppDaemon server after the update? Could you share the instance app configuration for |
|
I just tried the following configuration: test:
module: controllerx
class: E1810Controller
controller: <id>
integration: zha
light: group.test_lights
smooth_power_on: trueand I haven't had any issues with the |
|
Sorry for delay.
Yes, actually I've restarted my RPi too.
So, both kitchen and hallway controllers works but none do smoth_power_on. One thing I noticed is that, when dimm_up button is hold, sometimes I get a message from ZHA in the logs:
I will turn debug on from ZHA and see if more things come. Not all the time I get errors from AppDaemon logs, so even do smooth_power_on doesn't work, it was not directly tied to that error message I first posted. (but the message keeps showing from time to time). My lights: Kitchen -> 6 x Ikea GU10 brigthness/color temperature version Groups: One other behavior, with this configuration above, I can bright/dim the lights by pressing button but not by holding button (both E1810 and E1743). However, I can tune color temp (E1810) by pressing or hold buttons (left/right). Thanks for any clue. |
|
Hi @jrbenito, I am guessing the problem is related to the way you created the group of lights. The way the groups are supported is by the group integration and not light group. For the moment, if you want to group lights, you will need to do it this way: https://www.home-assistant.io/integrations/group/ Let me know if you try and it solves the problem. I will need to give support to group of light grouped with the way you did it. |
|
Hi @xaviml, Well, I might be doing something wrong because below configurations has exactly the same behavior: groups.yaml: The only thing is, I have this config for Bathroom and the light group for kitchen and hall in the same apps.yaml. Does one config affects another? |
|
Interesting.. so this configuration gives the same error as the other one? Could you put the logs of this configuration in here? Also, does is work as expected (and without errors) without the smooth_power_on? |
|
Hi' Xavi. I get the exact same errors as jrbenito applying smooth power on to a single Ikea color bulb using a E1743 remote. Can't get it to work. My setup:
|
|
Hi @htvekov, it is very interesting. I don't happen to reproduce this on my set up (same controller and same integration). Does the light turns on at least? I will add some debug logs to see where the error might come from. |
|
Do you guys see "brightness" attribute when the light is off? like in this picture. |
|
All 'normal' functions work. But press and hold 'on' button doesn't turn on light. No, brightness attribute disappears and is NOT present when light is off.
|
|
I think I have spotted the error then. I got all my lights with z2m and they report the brightness as well when they are off and this is why I do not see any errors. However, I have seen that a line of code should be placed in an "else" condition. I will publish a release soon with this change and I will let you know to check if that fixed the error. Thank you for your answer. |
|
Your very welcome, Xavi 😊 Just had a quick check. All my lights both Ikea- and Hue bulbs (and Hue light groups as well) have no brigtness attribute set when turned off. So it's the bridge that doesn't send all attributes when light are off. Quite a pity, as I'm not able to set brightness on my Ikea bulbs when they're turned off... Looking forward to test, when you have new code ready, Xavi 👍 |
|
Hi guys I released v2.2.1b1 with a fix for this bug. These are the instructions to try the code: Through HACSIf you go to ControllerX in HACS, you can select in the menu Show Beta and install v2.2.1b1. Then you will need to restart your AppDaemon server. Through filesYou can download the dev branch and copy the controllerx folder inside apps into /config/appdaemon/apps/. Then you will need to restart your AppDaemon server. If you guys try it out, let me know about it. Thanks :) |
|
Hi' Xavi Just tested the smoot power on.
|
|
Hi, it seems you are still running v2.2.0 since the line that crashes is not there in v2.2.1b1. Try to click on "reinstall" or uninstall ControllerX and install again v2.1.1b1 |
|
Also, do not forget to restart AppDaemon addon. |
|
I will post my results as soon I get back home. My lights and controllers are all paired to HA via ZHA integration. |
|
Hi there, So here is my setup:
First one is an Ikea GU10 with color temp capability, it is off at the moment of the screenshot. Now, here are the same lights but all turned on:
Hence, both hue groups and Light groups (not groups of lights) report same capabilities and none report brightness when off. That might explain things. Just to clarify: light.accent is a device connected via ZHA, light.bathroom_master is a light group (light from platform group created on HA) and light.closet is a group provided by philips hue bridge. BRs, |
|
Thanks @jrbenito, as I suspected the problem was that the light did not show brightness when it was off. This caused an error in a line that was missplaced. I got it fixed in v2.2.1b1, if you follows the instructions I gave before, you can try and let me know if that fixed the problem. Also, if you want to try the group of light, you will need to do it through normal groups ("group.xxxxx"). Thanks for the detailed answer! |
|
Hi' Xavi. You've been busy coding 😁😎 I had to do a couple of restarts before the beta actually was loaded and used (even though HACS indicated that the beta was installed ?) Anyway, it works - but not perfectly. I'll try to explain the behaviour I experience 😊 On my setup (with Ikea color bulb on Hue Bridge) 'smooth power on' turns on the bulb at a little bit brighter state, than lowest possible and dims to minimum (within 0.1/0.2 seconds or so). Perhaps you should implement that brightness won't change on initial long press. Meaning that button has to be released and pressed again before brightness adjusting begins ? I'm not sure whether or not the startup brightness behaviour I experience can be dealt with ? In 'real life' it's really not a problem as the brightness on startup is only slightly higher than lowest possible and drops to lowest level within some 0.1 second) Thank you once again, Xavi 👍 |
|
Hi @htvekov, Thanks again for your extensive feedback on this issue. You turned out to be the tester star for this release 😄. I experience the same with z2m. This is because I had a problem with the brightness state and I had to turn on first the light and then change its brightness, this is why you see that behavior within 0.1s. However, I will double-check if that can be avoided, but I cannot assure anything. Respect the smooth power on when holding, it is expected. However, as you say it does not make sense to keep brightening if what you wanted is the minimum brightness. So, I will change this behavior. It will turn the light to minimum brightness and it won't change the brightness. However, you will be able to brighten up a little bit if you hold up again. I will keep you updated. |
|
Well, it was quicker than I thought to fix. You can download now from HACS v2.2.1b2. I fixed the following:
Let me know if this is the behavior now. Thank you for your testing @htvekov and @jrbenito. |
|
Holy crap, you're quick Xavi 🚀🚀😁 Tested new beta fw and 'smooth power on' works perfect in my setup now.
All in all perfect behaviour in my setup - Nice job, Xavi 😎👍 |
|
This issue has been fixed in v2.2.1 |
Tried to activate smooth_power_on feature but it seems not working (after press and hold dim up button I expect the lights to turn on). Lights do nothing and logs below appear.
Other functions are working.
AppDaemon: 4
hass-core: 0.105.2
Device: Ikea Control E1810 and E1743
Integration: zha
Logs (if applicable):
The text was updated successfully, but these errors were encountered: