Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[CoreData] Move CoreData into the .NET age. (#13718)
* Remove obsolete API from .NET. * Change API marked with XAMCORE_4_0 due to naming problems to be in .NET. * Change API marked with XAMCORE_4_0 due to using non-generic NSDictionary to be in XAMCORE_5_0 instead (yay!). This is because of #13704, which can make using generic NSDictionary in API buggy, and I feel it's a bit too risky to change this for .NET with the time we have available (no time to fix #13704). Additionally, moving this to XAMCORE_5_0 makes it possible to keep grepping for XAMCORE_4_0 to see what's left. Update all the CoreData API to be better as defined by our XAMCORE_4_0 define. Mostly using generic NSSet/NSDictionary types instead of the non-generic ones, and other misc naming improvements. * Change API marked with XAMCORE_4_0 due to both of the above to do both of the above - add a version of the naming issue fixed for .NET + a version with the generic dictionary for XAMCORE_5_0.
- Loading branch information
e963fc6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ [CI Build] Tests failed on Build ❌
Tests failed on Build.
API diff
✅ API Diff from stable
View API diff
View dotnet API diff
View dotnet legacy API diff
View dotnet iOS-MacCatalayst API diff
API Current PR diff
ℹ️ API Diff (from PR only) (please review changes)
View API diff
View dotnet API diff
View dotnet legacy API diff
View dotnet iOS-MacCatalayst API diff
Generator diff
ℹ️ Generator Diff (please review changes)
Packages generated
View packages
Test results
2 tests failed, 233 tests passed.
Failed tests
Tests run: 2622 Passed: 2466 Inconclusive: 9 Failed: 1 Ignored: 155)
Tests run: 2619 Passed: 2464 Inconclusive: 9 Failed: 1 Ignored: 154)
Pipeline on Agent XAMBOT-1037.BigSur'
[CoreData] Move CoreData into the .NET age. (#13718)
e963fc6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥 Tests failed catastrophically on VSTS: device tests tvOS (no summary found). 🔥
Result file D:\a\1\s\Reports\TestSummary-tvos\TestSummary.md not found.
Generator diff comments have not been provided.
Pipeline on Agent
[CoreData] Move CoreData into the .NET age. (#13718)
e963fc6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥 Tests failed catastrophically on VSTS: device tests iOS (no summary found). 🔥
Result file D:\a\1\s\Reports\TestSummary-iOS64\TestSummary.md not found.
Generator diff comments have not been provided.
Pipeline on Agent
[CoreData] Move CoreData into the .NET age. (#13718)
e963fc6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Tests failed on macOS Mac Catalina (10.15) ❌
Tests failed on Mac Catalina (10.15).
Failed tests are:
Pipeline on Agent
[CoreData] Move CoreData into the .NET age. (#13718)