[CoreData] Move CoreData into the .NET age. #13718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove obsolete API from .NET. * Change API marked with XAMCORE_4_0 due to naming problems to be in .NET. * Change API marked with XAMCORE_4_0 due to using non-generic NSDictionary to be in XAMCORE_5_0 instead (yay!). This is because of xamarin#13704, which can make using generic NSDictionary in API buggy, and I feel it's a bit too risky to change this for .NET with the time we have available (no time to fix xamarin#13704). Additionally, moving this to XAMCORE_5_0 makes it possible to keep grepping for XAMCORE_4_0 to see what's left. Update all the CoreData API to be better as defined by our XAMCORE_4_0 define. Mostly using generic NSSet/NSDictionary types instead of the non-generic ones, and other misc naming improvements. * Change API marked with XAMCORE_4_0 due to both of the above to do both of the above - add a version of the naming issue fixed for .NET + a version with the generic dictionary for XAMCORE_5_0.
rolfbjarne
added
not-notes-worthy
mandel-macaque
approved these changes
Jan 13, 2022
dalexsoto
approved these changes
Jan 14, 2022
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View dotnet API diffView dotnet legacy API diffAPI Current PR diffℹ️ API Diff (from PR only) (please review changes) View dotnet API diffView dotnet legacy API diffGenerator diffℹ️ Generator Diff (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results3 tests failed, 145 tests passed.Failed tests
Pipeline on Agent XAMBOT-1106.BigSur' |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
chamons
approved these changes
Jan 14, 2022
tj-devel709
approved these changes
Jan 14, 2022
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View dotnet API diffView dotnet legacy API diffAPI Current PR diffℹ️ API Diff (from PR only) (please review changes) View dotnet API diffView dotnet legacy API diffGenerator diffℹ️ Generator Diff (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results3 tests failed, 145 tests passed.Failed tests
Pipeline on Agent XAMBOT-1100.BigSur' |
|
Test failures are unrelated:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in XAMCORE_5_0 instead (yay!). This is because of All empty NSDictionary instances have the same underlying native handle #13704, which can make using
generic NSDictionary in API buggy, and I feel it's a bit too risky to change this
for .NET with the time we have available (no time to fix All empty NSDictionary instances have the same underlying native handle #13704). Additionally,
moving this to XAMCORE_5_0 makes it possible to keep grepping for XAMCORE_4_0 to
see what's left. Update all the CoreData API to be better as defined by our XAMCORE_4_0
define. Mostly using generic NSSet/NSDictionary types instead of the non-generic
ones, and other misc naming improvements.
above - add a version of the naming issue fixed for .NET + a version with the generic
dictionary for XAMCORE_5_0.