Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for mean.jl #149

Merged
merged 3 commits into from
Dec 17, 2022
Merged

Add tests for mean.jl #149

merged 3 commits into from
Dec 17, 2022

Conversation

sayantikaSSG
Copy link
Collaborator

Add test cases to the mean.jl file according to #103 as stated in the following comment:

Codedev page for mean.jl illustrates which of the mean() functions tests have to be added for.

line 64, mean(x::Symbol,design::StratifiedSample)

line 127, mean(x::Symbol, by::Symbol, design::SimpleRandomSample)

line 142, mean(x::Symbol, by::Symbol, design::StratifiedSample)

@sayantikaSSG sayantikaSSG self-assigned this Dec 16, 2022
ayushpatnaikgit
ayushpatnaikgit reviewed Dec 16, 2022
View reviewed changes
test/mean.jl Outdated Show resolved Hide resolved
ayushpatnaikgit
ayushpatnaikgit reviewed Dec 16, 2022
View reviewed changes
test/mean.jl Outdated Show resolved Hide resolved
smishr and others added 2 commits December 17, 2022 10:55
@smishr @ayushpatnaikgit
remove comment
d25097c 
Co-authored-by: Ayush Patnaik <[email protected]>
@smishr @ayushpatnaikgit
clean up comment
7dd464b 
Co-authored-by: Ayush Patnaik <[email protected]>
smishr
smishr approved these changes Dec 17, 2022
View reviewed changes
Copy link
Contributor

@smishr smishr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to add

@smishr smishr linked an issue Dec 17, 2022 that may be closed by this pull request
Add tests mean.jl #103
Closed
@smishr smishr merged commit b146ad5 into xKDR:main Dec 17, 2022
@smishr
Copy link
Contributor

smishr commented Dec 17, 2022

i am merging the tests and closing #103

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayushpatnaikgit ayushpatnaikgit ayushpatnaikgit left review comments

@smishr smishr smishr approved these changes

Assignees

@sayantikaSSG sayantikaSSG

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add tests mean.jl
3 participants
@sayantikaSSG @smishr @ayushpatnaikgit