Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests mean.jl #103

Closed
smishr opened this issue Nov 29, 2022 · 3 comments · Fixed by #149
Closed

Add tests mean.jl #103

smishr opened this issue Nov 29, 2022 · 3 comments · Fixed by #149
Assignees
@sayantikaSSG
Labels
testing Related to testing suite
Milestone
Comprehensive tes...

Comments

@smishr
Copy link
Contributor

smishr commented Nov 29, 2022

Right now only rudimentary testing for mean.jl. Add tests, especially for CategoricalArray proportion calculations
@smishr smishr added this to the 0.2.0 release milestone Nov 29, 2022
@ayushpatnaikgit ayushpatnaikgit mentioned this issue Dec 4, 2022
Merged
This was referenced Dec 5, 2022
Closed
Closed
@smishr smishr pinned this issue Dec 6, 2022
@ayushpatnaikgit
Copy link
Member

@iuliadmtru I had done in modification in earlier PRs. Can you add the test cases?

@smishr smishr unpinned this issue Dec 8, 2022
@smishr smishr pinned this issue Dec 12, 2022
@smishr smishr changed the title Testing and modifying mean.jl Add tests mean.jl Dec 12, 2022
@smishr smishr added enhancement New feature or request testing Related to testing suite and removed enhancement New feature or request labels Dec 12, 2022
@smishr
Copy link
Contributor Author

smishr commented Dec 15, 2022

Codedev page for mean.jl illustrates which of the mean() functions tests have to be added for.

  • line 64, mean(x::Symbol, design::StratifiedSample)
  • line 127, mean(x::Symbol, by::Symbol, design::SimpleRandomSample)
  • line 142, mean(x::Symbol, by::Symbol, design::StratifiedSample)

@smishr
Copy link
Contributor Author

smishr commented Dec 16, 2022

@sayantikaSSG im assigning to you. it should be relatively easy to modify total.jl tests for mean.jl

@sayantikaSSG sayantikaSSG mentioned this issue Dec 16, 2022
Merged
@smishr smishr linked a pull request Dec 17, 2022 that will close this issue
Add tests for mean.jl #149
Merged
@smishr smishr unpinned this issue Dec 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sayantikaSSG sayantikaSSG

Labels
testing Related to testing suite
Projects
None yet
Milestone
Comprehensive testing suite and cover...
Development

Successfully merging a pull request may close this issue.

Add tests for mean.jl sayantikaSSG/Survey.jl
4 participants
@ayushpatnaikgit @smishr @iuliadmtru @sayantikaSSG