Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proportion and count estimation for SimpleRandomSample and StratifiedSample #81

Closed
smishr opened this issue Nov 9, 2022 · 4 comments
Closed
Assignees
Milestone

Comments

@smishr
Copy link
Contributor

smishr commented Nov 9, 2022

In R survey, population proportions and population total estimation is done by passing a 'factor' (CategoricalArray) variable to svymean svytotal (see pg 21 Lumley textbook).

Basic proportion and count estimation functionality was added to SimpleRandomSample and started for StratifiedSample, inside their respective svymean and svytotal functions to emulate functionality from R. This is currently done using an if statement

I am thinking that it would be neater and cleaner to have these features as multiple dispatch, instead of being caught by the if. Minor improvements in speed would also be there for very large datasets by using multiple dispatch.

@smishr smishr added the help wanted Extra attention is needed label Nov 9, 2022
@smishr smishr added this to the 0.2.0 release milestone Nov 9, 2022
@smishr smishr removed the help wanted Extra attention is needed label Nov 9, 2022
@smishr
Copy link
Contributor Author

smishr commented Nov 23, 2022

#89 adds some of this functionality

@smishr
Copy link
Contributor Author

smishr commented Nov 29, 2022

#102 Adds some more features

@smishr smishr assigned iuliadmtru and unassigned ayushpatnaikgit Nov 29, 2022
@smishr
Copy link
Contributor Author

smishr commented Nov 30, 2022

Still need to add more testing in test/mean.jl and test/total.jl for CategoricalArray

@iuliadmtru
Copy link
Contributor

Testing for CategoricalArray support is covered in issues #103 and #104.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants