Add configuration option for visually hidden space on SummaryListComponent::ActionComponent #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onent::ActionComponent
✅ Deploy Preview for govuk-components ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
I'm not sure this needs to be a configurable option... If it's needed we should always use it. That said, the upstream issue suggests that it might be an issue even with the non-breaking space. In the short term, could we do the small step of moving the existing space inside the |
|
PR looks good, as @frankieroberto says let's hold fire a while and see what happens upstream. Many thanks for submitting @paulodeon |
peteryates
added a commit
that referenced
this pull request
Mar 10, 2023
The final decision on how to properly handle the space between the visible and hidden text hasn't been made yet but the general consensus upstream is that it's better inside the visually hidden span than before it. This might be revisited again when a decision has been made and the solution presented in #403 can be used instead.
peteryates
added a commit
that referenced
this pull request
Mar 10, 2023
The final decision on how to properly handle the space between the visible and hidden text hasn't been made yet but the general consensus upstream is that it's better inside the visually hidden span than before it. This might be revisited again when a decision has been made and the solution presented in #403 can be used instead.
|
Closing this now as it seems shifting the space has done the trick. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per issue #402. We are adding a configuration option to allow moving the space in the summary list actions from the visually shown to visually hidden text.
I'm not sure whether we should be using nbsp or a regular space here but I've put in nbsp for now as that was the recommendation