-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hidden link text on Check answers pattern omit space character in JAWS #2547
Comments
Thanks to Craig Abbot for reporting this issue. |
Thanks @timpaul - it was originally raised by @htmlandbacon: GOVUK Design System issue 1382 The reason for raising it again it because both HMRC and DWP have published guidance which uses a different mechanism for change links. It involves duplicating the content and using aria-hidden on one. For example: <span aria-hidden="true">Change</span>
<span class="govuk-visually-hidden">Change Elizabeth Kean</span> If the CSS were to not load, then the visible link on the screen would be: Links: |
I re-tested this in Feb 2021 I couldn’t hear the merging of content anymore in JAWS (tested 2019, 2020, 2021), although the merging is still evident in the links list dialog (though again not audible). @abbott567 The original solution for the split copy included the use of a |
Just checked and NVDA is also still removing the space between the visible and hidden copy in the dialogs, although again I cannot hear the words merging. If we do find that the words are being audibly merged then another option was suggested by Andrew Arch Principal Accessibility Consultant at Intopia on the Govt Accessibility email list. This is using a capital letter for the first word of the hidden copy which might result in the non-honouring of the space to be negated by the screen-reader pronunciation of camelcased text eg ChangeName where the screen-reader will read out the words as individual words due to the casing. This does raise other issues however around implementation. Of course with browser and AT support being so much better now, there is the other option of doing away with hidden copy on links and use With both the HMRC/DWP and |
We've started getting more reports of this happening lately, including in screen readers other than JAWS (at least NVDA, VoiceOver and TalkBack). We've also noticed this occurring whilst working on other components like the Exit this Page button. These issues seem to happen (albeit inconsistently) regardless of if the space is inside or outside of the visually-hidden span. We may want to investigate a more robust method of doing this in future, such as some of the suggestions made above. This could potentially be done in conjunction with removing the hardcoded visually-hidden span in summary list links (#2649). |
Has this been solved by #3836? |
Have repeated Hanna's testing from #3836 and I'm confident we've solved this. |
The ‘Change’ links have hidden text, like this:
But apparently JAWS sometimes ignores the opening space in the hidden text, so it would read out
Changename
in the above example.We think one fix might be to use a non-breaking space character instead, so it'd look like this:
The text was updated successfully, but these errors were encountered: