-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTTP2 support in router #2953
Merged
Merged
HTTP2 support in router #2953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suksw
reviewed
Jun 6, 2022
suksw
reviewed
Jun 6, 2022
...nd-server/src/main/java/org/wso2/choreo/connect/mockbackend/http2/EchoHttpServerHandler.java
Show resolved
Hide resolved
suksw
reviewed
Jun 6, 2022
...nd-server/src/main/java/org/wso2/choreo/connect/mockbackend/http2/EchoHttpServerHandler.java
Show resolved
Hide resolved
pubudu538
reviewed
Jun 6, 2022
...ava/org/wso2/choreo/connect/tests/testcases/standalone/http2/Http2ClearTextApiTestCase2.java
Outdated
Show resolved
Hide resolved
VirajSalaka
reviewed
Jun 7, 2022
VirajSalaka
reviewed
Jun 7, 2022
...d-server/src/main/java/org/wso2/choreo/connect/mockbackend/http2/EchoHttp2ServerHandler.java
Show resolved
Hide resolved
VirajSalaka
reviewed
Jun 7, 2022
.../src/test/java/org/wso2/choreo/connect/tests/testcases/withapim/Http2SecuredApiTestCase.java
Outdated
Show resolved
Hide resolved
VirajSalaka
reviewed
Jun 7, 2022
.../src/test/java/org/wso2/choreo/connect/tests/testcases/withapim/Http2SecuredApiTestCase.java
Outdated
Show resolved
Hide resolved
VirajSalaka
reviewed
Jun 7, 2022
...rc/test/java/org/wso2/choreo/connect/tests/testcases/withapim/Http2ClearTextApiTestCase.java
Outdated
Show resolved
Hide resolved
VirajSalaka
reviewed
Jun 7, 2022
...rc/test/java/org/wso2/choreo/connect/tests/testcases/withapim/Http2ClearTextApiTestCase.java
Outdated
Show resolved
Hide resolved
VirajSalaka
reviewed
Jun 7, 2022
integration/test-integration/src/test/resources/testng-cc-with-apim.xml
Outdated
Show resolved
Hide resolved
Amila-Rukshan
commented
Jun 9, 2022
pubudu538
reviewed
Jun 28, 2022
pubudu538
approved these changes
Jun 29, 2022
VirajSalaka
reviewed
Jun 29, 2022
VirajSalaka
approved these changes
Jun 29, 2022
LGTM |
AmaliMatharaarachchi
approved these changes
Jul 5, 2022
AmaliMatharaarachchi
approved these changes
Jul 5, 2022
pubudu538
approved these changes
Jul 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This is to support http2 protocol support for upstream connections. Currently envoy only support http2 with prior knowledge (http2_protocol_options section in https://www.envoyproxy.io/docs/envoy/v1.20.3/api-v3/config/cluster/v3/cluster.proto#config-cluster-v3-cluster). Hence swagger vendor extension added to enable http2 connections in upstream clusters of that API.
Following extension property should be added to OAS definition.
NOTE: Once this ticket (envoyproxy/envoy#1502) is done in envoy side, we can remove this config by enabling both http1 and http2 (http2 upgrade and direct http2 calls) by default.
Envoy listener supports both http1, http2 with and without prior knowledge. Default to AUTO configuration where both http1 and http2 connections are allowed. By adding following configuration in
config.toml
, it can be set to a specific protocol version.Issues
Fixes #2904
Automation tests
Tested environments
Tested
OS: Darwin
Env: Docker
Observations
Envoy was tested with a sample http2 server with server push. Both upstream and downstream http2 connections are established using http2. When browser tries to send h2 upgrade call it fails to create the connection. Later find out that the server push feature is not implemented yet as mentioned in this file: https://github.com/envoyproxy/envoy/blob/main/api/envoy/api/v2/core/protocol.proto#L269
Maintainers: Check before merge