Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify Envoy recommendations as an edge proxy #2813

Closed
pubudu538 opened this issue Mar 28, 2022 · 2 comments
Closed

Verify Envoy recommendations as an edge proxy #2813

pubudu538 opened this issue Mar 28, 2022 · 2 comments

Comments

@pubudu538
Copy link
Contributor

Describe your problem(s)

Verify Envoy recommendations for CC - https://www.envoyproxy.io/docs/envoy/latest/configuration/best_practices/edge#best-practices-edge

Describe your solution

How will you implement it


Optional Fields

Related Issues:

Suggested Labels:

Suggested Assignees:

@NomadXD
Copy link
Contributor

NomadXD commented Jun 16, 2022

1. use_remote_address - Implemented in #2959

2. overload_manager - Ignored

Prevent crashing due to OOM errors by rejecting new connections or closing down connections. No extra benefit compared to K8s deployment with liveness probe. Also not possible to configure with xDS since this falls under bootstrap config. Therefore ignored.

3. Listener buffer limits / Cluster buffer limits - Ignored

Both listener buffer limit and cluster limit are soft limits in envoy. So the existing connections are not closed depending on the buffer value. Buffer value is only used for watermark and drain implementation to copy request/response bytes. For edge proxy config, the recommendation is to set per_connection_buffer_limit_bytes to 32 KiB. But for large payloads, it takes more time to copy and it raises concerns regarding timeouts.

4. Connection and Stream timeouts - Already configured under route config

5. HTTP/2 related config - Added in #2953

6. Global downstream connection limits - Already configured to 2147483647

7. headers_with_underscores_action setting - Ignored

8. path_with_escaped_slashes_action setting - Ignored

cc @pubudu538 @VirajSalaka

@pubudu538
Copy link
Contributor Author

As we have addressed the concerns above I am closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants