⬆️: Upgrade Expo SDK to 48 #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 複数のバージョンの@expo/config-pluginsが混在していると、@expo/config-pluginsに適用するパッチのパス(@expo/cliが参照する@expo/config-plugins)が変わってしまう - 上記事象を解消するために、devDependenciesに@expo/cliで使用する@expo/config-pluginsと同じバージョンを追加することで、パッチを適用するパスが固定されるようにする
creature-water-valley
force-pushed
the
feature/upgrade-expo-48
branch
from
b189f10
to
7faf8ae
Compare
creature-water-valley
force-pushed
the
feature/upgrade-expo-48
branch
from
7faf8ae
to
1d844a0
Compare
fix virtualizedList scrollToEnd for 0 items(facebook/react-native#36067)
upgrade react-native 0.71 (expo/expo@84f418d)
upgrade react-native 0.71 (expo/expo@84f418d)
[templates] Remove config options that don't apply to templates(expo/expo@ff9831c)
creature-water-valley
force-pushed
the
feature/upgrade-expo-48
branch
from
1d844a0
to
8ddbea2
Compare
2 tasks
creature-water-valley
referenced
this pull request
in ws-4020/mobile-app-crib-notes
May 8, 2023
## ✅ What's done [`rn-spoiler`のExpo SDK 48アップグレード対応](https://github.com/ws-4020/rn-spoiler/pull/133)で以下を検知 ToDo一覧画面のFAB（Icon）は、`react-native-elements`の`Icon`を使用していますが、`raised`を指定した場合に以下のWarningが出力されます。 > WARN (ADVICE) View #355 of type RCTView has a shadow set but cannot calculate shadow efficiently. Consider setting a background color to fix this, or apply the shadow to a more specific component. `shadow`関連のPropsを扱う場合は`backgroundColor`も設定した方が良いという警告ですが、`raised`を`true`に設定した場合に、`react-native-elements`では`backgroundColor`を設定していないようです。 - https://github.com/react-native-elements/react-native-elements/blob/v3.4.3/src/icons/Icon.tsx#L177 ToDoアプリでは、`Icon`の`raised`の使用を学習の目的としていないので、ToDo一覧画面のFAB（Icon）から`raised`を削除しました。 - [x] `raised`の削除 - 以下で対象を確認（`shadow`系のPropsを使用していないかも併せて確認） - `git grep -E "raised|shadow[Color|Offset|Opacity|Radius]" -- website/` - [x] ToDo一覧画面のキャプチャを貼り付ける箇所のキャプチャ更新
tksugimoto
reviewed
May 8, 2023
tksugimoto
reviewed
May 8, 2023
tksugimoto
reviewed
May 8, 2023
tksugimoto
reviewed
May 8, 2023
tksugimoto
reviewed
May 9, 2023
tksugimoto
reviewed
May 9, 2023
tksugimoto
reviewed
May 9, 2023
github-actions
bot
added
the
chore
tksugimoto
reviewed
May 9, 2023
tksugimoto
approved these changes
May 9, 2023
in-a-paddy
approved these changes
May 10, 2023
27 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ What's done
npm install expo@^48.0.0を実行してExpo SDKをアップグレードnpx expo install --fixを実行してExpo管理のライブラリをアップグレードnpx expo install --fixで更新されないライブラリの更新@expo/config-pluginsをdevDependenciesに追加expoや@react-native-firebase/appが依存ライブラリとして追加している@expo/config-pluginsのバージョンが違い、@expo/config-pluginsに適用するパッチのパスが変わってしまうdevDependenciesに@expo/cliで使用する@expo/config-pluginsと同じバージョンを追加@expo/config-pluginsのパッチファイルを更新@types/react-nativereact-domreact-native-webFlatListでデータが0件の場合にscrollToEndを呼び出すとエラーになる問題の対処としてパッチを追加buckconfigの削除.gitignoreの更新app.config.jsの更新renovate5.jsonの更新@types/react-nativejest-exporeact-domreact-native-webTests
npm run create-app:hands-onDevices
Other (messages to reviewers, concerns, etc.)
なし