⬆️: Upgrade Expo SDK to 49 #1221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patch-package の修正は別途対応
変更しなくても動作はするがwarningがでるため
v0.72.0から対応済み
以下への対応 Improve handling of invalid DimensionValue usage facebook/react-native@02e29ab ```diff -width?: number | string | undefined; +width?: DimensionValue | undefined; ``` ```ts export type DimensionValue = | number | 'auto' | `${number}%` | Animated.AnimatedNode | null; ```
以下への対応 feat: Fabric support react-native-webview/react-native-webview@5558e28 ```diff -onScroll?: (event: WebViewScrollEvent) => void; +onScroll?: ComponentProps<typeof NativeWebViewComponent>['onScroll']; ```
以下への対応 🤖 Merge [react] Allow returning ReactNode from function com… DefinitelyTyped/DefinitelyTyped@443451c ```diff interface FunctionComponent<P = {}> { - (props: P, context?: any): ReactElement<any, any> | null; + (props: P, context?: any): ReactNode; ```
github-actions
bot
added
app
build
chore
|
/azp run deploy-all |
|
Azure Pipelines successfully started running 1 pipeline(s). |
tksugimoto
force-pushed
the
feature/upgrade-expo-49
branch
from
a91afb3
to
bda45e2
Compare
Cannot find module 'react-native-reanimated/lib/reanimated2/jestUtils' from 'jest/setup/react-native-reanimated.js'
以下変更の対応 ESM Dimensions facebook/react-native@c52ed25 ```diff get Dimensions(): Dimensions { - return require('./Libraries/Utilities/Dimensions'); + return require('./Libraries/Utilities/Dimensions').default; }, ```
以下の警告が出るようになっていたため - Warning: An update to ForwardRef inside a test was not wrapped in act(...). - When testing, code that causes React state updates should be wrapped into act(...):
> Constants.manifest has been deprecated in favor of Constants.expoConfig.
※ ...jest.requireActual('expo-constants') を使うと別のテストが落ちた
> TypeError: Cannot read properties of null (reading 'uri')
> at Function.uri [as fromModule] (node_modules/expo-asset/src/Asset.ts:156:15)
※ wrapPropertyの第二引数のpropertyObj: objectの型をPartial<T>にするのは型解決ができず断念
> 型 'string | symbol' の式を使用して型 'Partial<T>' にインデックスを付けることはできないため、要素は暗黙的に 'any' 型になります。
また、T extends object なので追加で不正なkey:value追加は検知できなかった
[修正前のtest結果]
expect(jest.fn()).not.toHaveBeenCalled()
Expected number of calls: 0
Received number of calls: 1
1: true
151 | jest.advanceTimersByTime(99);
152 | });
> 153 | expect(afterSlideOut).not.toHaveBeenCalled();
| ^
154 | // slideOutDurationで指定した時間経過後は、afterSlideOutが実行される
155 | await act(() => {
156 | jest.advanceTimersByTime(1);
at Object.toHaveBeenCalled (src/bases/ui/picker/PickerContainer.test.tsx:153:31)
発生していたWARNログ ============= WARNING: You are currently running a version of TypeScript which is not officially supported by @typescript-eslint/typescript-estree. You may find that it works just fine, or you may not. SUPPORTED TYPESCRIPT VERSIONS: >=3.3.1 <5.1.0 YOUR TYPESCRIPT VERSION: 5.1.6 Please only submit bug reports when using the officially supported version. ============= 実行コマンド npm update @typescript-eslint/eslint-plugin @typescript-eslint/parser
eslint error error 'JSX' is deprecated. Use `React.JSX` instead of the global `JSX` namespace deprecation/deprecation
> initialScrollIndex "-1" is not valid (list has 0 items) react-native v0.72.0での変更 Gracefully handle out-of-bounds initialScrollIndex facebook/react-native@aab9df3
個別に記載するほどの分量が無かったため
個別に記載するほどの分量が無かったため
元々deprecatedだったものは未記載
- 冗長な表現を削除 - Expo目線をやめる
creature-water-valley
approved these changes
Sep 14, 2023
2 tasks
6 tasks
|
/azp run deploy-all |
|
Azure Pipelines successfully started running 1 pipeline(s). |
- react-native-svg用設定を削除（ライブラリ側で対応されたため） - software-mansion/react-native-svg@1637580 - expo用設定のコメントのURLをExpo49に更新(コードに大差ないので依然として対応は必要と思われる)
tksugimoto
force-pushed
the
feature/upgrade-expo-49
branch
from
a19102e
to
04fca98
Compare
typescript v5.2を使うとnpm run lint:tscで以下のWARNが出るためv5.1.xまでを指定 ============= WARNING: You are currently running a version of TypeScript which is not officially supported by @typescript-eslint/typescript-estree. You may find that it works just fine, or you may not. SUPPORTED TYPESCRIPT VERSIONS: >=3.3.1 <5.2.0 YOUR TYPESCRIPT VERSION: 5.2.2 ============= バージョン互換性の記載場所 https://github.com/typescript-eslint/typescript-eslint/blob/v5.62.0/packages/typescript-estree/src/parseSettings/warnAboutTSVersion.ts#L9 > const SUPPORTED_TYPESCRIPT_VERSIONS = '>=3.3.1 <5.2.0'; ※ typescript-eslintは以下のライブラリでv5が要求されている - eslint-config-universe v11.x - expo-module-scripts v3.0.x
tksugimoto
force-pushed
the
feature/upgrade-expo-49
branch
from
5366934
to
cf4bd28
Compare
website/docs/react-native/santoku/maintenance/enhance/expo-49-upgrade.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: creature-water-valley <[email protected]>
in-a-paddy
reviewed
Sep 19, 2023
website/docs/react-native/santoku/maintenance/enhance/expo-49-upgrade.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: In-a-Paddy <[email protected]>
website/docs/react-native/santoku/maintenance/enhance/expo-49-upgrade.mdx
Show resolved
Hide resolved
in-a-paddy
approved these changes
Sep 19, 2023
htmltestからのmarketplace.visualstudio.comへのアクセスは404になってしまうらしい
Merged
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ What's done
react-native-svg)^5.1.3→~5.1.3(互換性対応).gitignoreの更新Tests
以下のコマンドをこのプルリクエストのコメントとして投稿すると、
Azure Pipeline上でSantokuAppをビルドしてDeployGateへアップロードできます。
stg,devの両方Devices
Other (messages to reviewers, concerns, etc.)
関連