[wpimath] Add feedforward constant constructor to ElevatorSim #5823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…edforward.java Co-authored-by: Tyler Veness <[email protected]>
Windows 8 added GetSystemTimePreciseAsFileTime().
|
I don't understand what the cpp error is. Something about units, but the units should fine. |
|
/format |
calcmogul
reviewed
Oct 31, 2023
|
/format |
calcmogul
reviewed
Oct 31, 2023
| @@ -75,9 +85,11 @@ units::ampere_t ElevatorSim::GetCurrentDraw() const { | |||
| // is spinning 10x faster than the output. | |||
|
|
|||
| // v = r w, so w = v / r | |||
There was a problem hiding this comment.
This comment doesn't belong to the newly added code.
|
/format |
|
I think this is done. Is there anything else I need to finish? |
calcmogul
requested changes
Nov 2, 2023
|
Should that breaking change be made in other sim classes? |
Not yet. I have other PR's waiting for those. But I haven't submitted yet. |
calcmogul
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a subclass of ElevatorSim that uses kG, kV, and kA from sysId to simulate an Elevator.