SendableBuilder: Add PublishConst methods #5158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there a reason this is suspended to 2024? It's not breaking. |
|
Any change to the SendableBuilder interface is breaking in C++. |
Starlight220
force-pushed
the
send-const
branch
from
55edfce to
4ce2d37
Compare
Starlight220
force-pushed
the
send-const
branch
from
4ce2d37 to
2e5cae6
Compare
|
@PeterJohnson now that we're merging breaking changes, is there anything else blocking this? |
wpilibc/src/main/native/include/frc/smartdashboard/SendableBuilderImpl.h
Outdated
Show resolved
Hide resolved
wpilibc/src/main/native/cpp/smartdashboard/SendableBuilderImpl.cpp
Outdated
Show resolved
Hide resolved
wpilibc/src/main/native/cpp/smartdashboard/SendableBuilderImpl.cpp
Outdated
Show resolved
Hide resolved
|
/format |
PeterJohnson
requested changes
Oct 1, 2023
wpilibc/src/main/native/cpp/smartdashboard/SendableBuilderImpl.cpp
Outdated
Show resolved
Hide resolved
PeterJohnson
approved these changes
Oct 2, 2023
calcmogul
pushed a commit
to narmstro2020/allwpilib
that referenced
this pull request
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unblocks #4735.