Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #7018: Wrong OCI if scroll happens before beacon fires. #7020

Closed
wants to merge 1 commit into from

Conversation

Miraeld
Copy link
Contributor

@Miraeld Miraeld commented Oct 8, 2024

Description

Fixes #7018
The beacon won't be triggered if the page has been scrolled before the initial start.

Type of change

  • Bug fix (non-breaking change which fixes an issue).

Detailed scenario

Technical description

Documentation

Refer to wp-media/rocket-scripts#32

New dependencies

Updated dependencies: rocket-scripts

Risks

None

Mandatory Checklist

Code validation

  • I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Code style

  • I wrote a self-explanatory code about what it does.
  • I protected entry points against unexpected inputs.
  • I did not introduce unnecessary complexity.
  • Output messages (errors, notices, logs) are explicit enough for users to understand the issue and are actionnable.

@Miraeld Miraeld added the type: bug Indicates an unexpected problem or unintended behavior label Oct 8, 2024
@Miraeld Miraeld requested a review from a team October 8, 2024 11:49
@Miraeld Miraeld self-assigned this Oct 8, 2024
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 09708aa1 (target: 50.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (09708aa) Report Missing Report Missing Report Missing
Head commit (bad42d1) 37744 16585 43.94%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#7020) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

Copy link
Contributor

@hanna-meda hanna-meda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Miraeld, thank you for this PR.
Looking good on test env.
Tests Results Report below:
testrail-report-645.pdf

@Khadreal Khadreal closed this Oct 16, 2024
@Khadreal
Copy link
Contributor

The PR here covers for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong OCI if scroll happens before beacon fires - Update rocket-scripts dependencies
4 participants