Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong OCI if scroll happens before beacon fires - Update rocket-scripts dependencies #7018

Closed
Miraeld opened this issue Oct 8, 2024 · 0 comments · Fixed by #7036
Closed

Wrong OCI if scroll happens before beacon fires - Update rocket-scripts dependencies #7018

Miraeld opened this issue Oct 8, 2024 · 0 comments · Fixed by #7036
Assignees
@Miraeld
Milestone
3.17.2

Comments

@Miraeld
Copy link
Contributor

Miraeld commented Oct 8, 2024

Describe the bug
Wrong OCI will be picked up if the page is scrolled before the beacon script runs.
This issue is here to update the rocket-scripts dependency once it's been fixed on rocket-scripts side.
@Miraeld Miraeld self-assigned this Oct 8, 2024
@Miraeld Miraeld added type: bug Indicates an unexpected problem or unintended behavior and removed type: bug Indicates an unexpected problem or unintended behavior labels Oct 8, 2024
Miraeld added a commit that referenced this issue Oct 8, 2024
@Miraeld
Closes #7018: Wrong OCI if scroll happens before beacon fires.
bad42d1
@Miraeld Miraeld mentioned this issue Oct 8, 2024
Closed
8 tasks
@piotrbak piotrbak added this to the 3.17.2 milestone Oct 10, 2024
@MathieuLamiot MathieuLamiot linked a pull request Oct 17, 2024 that will close this issue
Update rocket script version for WPR #7036
Merged
8 tasks
@wordpressfan wordpressfan mentioned this issue Oct 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Miraeld Miraeld

Labels
None yet
Projects
None yet
Milestone
3.17.2
2 participants
@Miraeld @piotrbak