Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Worldchain testnet #4140

Conversation

bruce-riley
Copy link
Contributor

@bruce-riley bruce-riley commented Oct 21, 2024

This PR deploys World Chain to testnet and adds guardian support for it.

  • The core is available here.
  • The token bridge is available here.

The change ethereum/sh/registerAllChainsOnTokenBridge.sh is to enabling registering the other chains on a new chain before support for this chain is added to sdk-v2 and the worm cli. It just removes an unnecessary check.

@bruce-riley bruce-riley marked this pull request as ready for review October 21, 2024 17:49
panoel
panoel previously approved these changes Oct 21, 2024
Copy link
Contributor

@panoel panoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't verify the token bridge emitter address.

evan-gray
evan-gray previously approved these changes Oct 21, 2024
Copy link
Contributor

@evan-gray evan-gray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment regarding WETH config

ethereum/env/.env.worldchain.testnet Outdated Show resolved Hide resolved
@bruce-riley bruce-riley dismissed stale reviews from evan-gray and panoel via f772d14 October 21, 2024 19:34
@bruce-riley bruce-riley requested a review from panoel October 21, 2024 20:30
Copy link
Contributor

@gator-boi gator-boi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the ethereum directory.

@bruce-riley bruce-riley merged commit abd0b33 into wormhole-foundation:main Oct 21, 2024
24 checks passed
@bruce-riley bruce-riley deleted the deploy_worldchain_testnet branch October 21, 2024 21:20
kakucodes pushed a commit to kakucodes/wormhole that referenced this pull request Dec 10, 2024
…ion#4103)

The `set -u` options in these scripts caused them to fail with 'unbound
variable' errors when CLI args or env variables were unset. This commit
fixes the validation so that the scripts output usage info or helpful
errors instead of exiting with unbound variable errors that the user
must read the source to diagnose.

for the script `ethereum/sh/upgrade_all_testnet.sh`, the commit updates
a variable name that appears incorrect.

node/hack: Print potential USD stablecoins that appear depegged (wormhole-foundation#4130)

* node/hack: Print potential USD stablecoins that appear depegged

* PR feedback

whitepapers: Clarify CCQ sol_pda support (wormhole-foundation#4129)

GitHub: Update code owners for go sdk (wormhole-foundation#4133)

Deploy Unichain testnet (wormhole-foundation#4134)

* Deploy Unichain testnet

* Add snaxchain to proto

node: Governor token list update (wormhole-foundation#4126)

* node: governor token list update

* Manually fix token price

---------

Co-authored-by: djb15 <[email protected]>

docs: Update SECURITY.md

Replace Guardian Key with abstracted Guardian Signer (wormhole-foundation#4120)

* node: add guardiansigner node/pkg

* node: replace use of guardian key with guardian signer

* node: replace use of vaa.AddSigner with guardian signer

* node: add nolint for armor import and fix test

* node: handle error returned from signing

* apply draft review suggestions

* apply pr reviews

* apply pr reviews

* apply pr reviews

* apply pr reviews

---------

Co-authored-by: pleasew8t <[email protected]>

Deploy Worldchain testnet (wormhole-foundation#4140)

* Deploy Worldchain testnet

* Update WETH address

* Fix cli test and add token bridge VAAs

add deprecation warning to the top of SDK readme (wormhole-foundation#4142)

spy: respect --port if set (wormhole-foundation#4139)

codeowners: Update for audits folder (wormhole-foundation#4144)

Deploy Monad Devnet (wormhole-foundation#4145)

* Deploy Monad Devnet

* Code review rework

docs: Audit reports (wormhole-foundation#4143)

* docs: Audit reports

* Rename

cosmwasm: add wormchain ibc receiver tests (wormhole-foundation#4121)

cosmwasm: add support for json schemas for all contracts (wormhole-foundation#4118)

* cosmwasm: add support for json schemas for all contracts

* cosmwasm: fixed formatting as per the linter

Node: Remove cutover checks (wormhole-foundation#4149)

Add interchaintest tests to wormchain
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants