cosmwasm: add support for json schemas for all contracts #4118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kakucodes
requested review from
nik-suri,
kcsongor and
a5-pickle
as code owners
jtieri
approved these changes
Oct 7, 2024
There was a problem hiding this comment.
The Strangelove team reviewed this as part of a live coding review session and concluded that the changes look fine and should not affect core functionality, the changes just add the ability to export JSON schemas which are useful when interacting with the contracts from other programming languages.
felix-asym
reviewed
Oct 10, 2024
6 tasks
felix-asym
approved these changes
Oct 18, 2024
nik-suri
approved these changes
Oct 28, 2024
kakucodes
pushed a commit
to kakucodes/wormhole
that referenced
this pull request
Dec 10, 2024
…ion#4103) The `set -u` options in these scripts caused them to fail with 'unbound variable' errors when CLI args or env variables were unset. This commit fixes the validation so that the scripts output usage info or helpful errors instead of exiting with unbound variable errors that the user must read the source to diagnose. for the script `ethereum/sh/upgrade_all_testnet.sh`, the commit updates a variable name that appears incorrect. node/hack: Print potential USD stablecoins that appear depegged (wormhole-foundation#4130) * node/hack: Print potential USD stablecoins that appear depegged * PR feedback whitepapers: Clarify CCQ sol_pda support (wormhole-foundation#4129) GitHub: Update code owners for go sdk (wormhole-foundation#4133) Deploy Unichain testnet (wormhole-foundation#4134) * Deploy Unichain testnet * Add snaxchain to proto node: Governor token list update (wormhole-foundation#4126) * node: governor token list update * Manually fix token price --------- Co-authored-by: djb15 <[email protected]> docs: Update SECURITY.md Replace Guardian Key with abstracted Guardian Signer (wormhole-foundation#4120) * node: add guardiansigner node/pkg * node: replace use of guardian key with guardian signer * node: replace use of vaa.AddSigner with guardian signer * node: add nolint for armor import and fix test * node: handle error returned from signing * apply draft review suggestions * apply pr reviews * apply pr reviews * apply pr reviews * apply pr reviews --------- Co-authored-by: pleasew8t <[email protected]> Deploy Worldchain testnet (wormhole-foundation#4140) * Deploy Worldchain testnet * Update WETH address * Fix cli test and add token bridge VAAs add deprecation warning to the top of SDK readme (wormhole-foundation#4142) spy: respect --port if set (wormhole-foundation#4139) codeowners: Update for audits folder (wormhole-foundation#4144) Deploy Monad Devnet (wormhole-foundation#4145) * Deploy Monad Devnet * Code review rework docs: Audit reports (wormhole-foundation#4143) * docs: Audit reports * Rename cosmwasm: add wormchain ibc receiver tests (wormhole-foundation#4121) cosmwasm: add support for json schemas for all contracts (wormhole-foundation#4118) * cosmwasm: add support for json schemas for all contracts * cosmwasm: fixed formatting as per the linter Node: Remove cutover checks (wormhole-foundation#4149) Add interchaintest tests to wormchain
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this pull request is to update the cosmwasm contracts with the ability to export json schemas. These schemas are useful not only for frontend consumption (Typescript codegeneration) but also for Go and Interchain Test.
By and large the changes make all of the existing cosmwasm contracts a bit more homogeneous and fix some style differences between them. I added
cosmwasm-schemawhere it didn't already exist and annotated query return types where they were not already specified. Additionally I swapped out the older style trait derives for serializable data types to use thecw_serdemacro again for the sake of homogeneity in the workspace.