-
Notifications
You must be signed in to change notification settings - Fork 691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
evm: add token and nft bridge interface #1710
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gator-boi
requested review from
evan-gray,
kcsongor,
a5-pickle and
kev1n-peters
October 11, 2022 15:44
gator-boi
force-pushed
the
gator-boi/evm-interfaces
branch
from
October 11, 2022 16:30
93f91b7
to
7f15e6f
Compare
evan-gray
force-pushed
the
gator-boi/evm-interfaces
branch
from
October 26, 2022 19:41
7f15e6f
to
7885a07
Compare
a5-pickle
previously approved these changes
Oct 26, 2022
evan-gray
requested changes
Oct 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Standby, @kcsongor and I have a sweet test idea to make sure these match the contracts!
evan-gray
force-pushed
the
gator-boi/evm-interfaces
branch
from
October 28, 2022 14:35
ee614d6
to
636337d
Compare
kcsongor
approved these changes
Oct 28, 2022
evan-gray
approved these changes
Oct 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌
This was referenced Oct 12, 2024
This was referenced Oct 16, 2024
This was referenced Oct 16, 2024
This was referenced Oct 19, 2024
This was referenced Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to add interface files for the Core, TokenBridge and NFTBridge contracts for all public methods. Currently, integrators are forced to create their own interfaces files to interact with Wormhole contracts.