Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

evm: add token and NFT bridge interface #1600

Closed
wants to merge 1 commit into from
Closed

Conversation

wonge97
Copy link
Contributor

@wonge97 wonge97 commented Sep 15, 2022

No description provided.

@wonge97 wonge97 force-pushed the wonge97/evm-interface branch 5 times, most recently from 989e47d to d5e1458 Compare September 21, 2022 18:18
@mizdler
Copy link

mizdler commented Oct 8, 2022

Hi Wormhole team,
As a project that is built on top of Wormhole Core Bridge and Token Bridge, this PR is what we really needed!
We were looking for an interface for Token Bridge and since there was no interface at the time, we created one.
In our code we are using couple of more public functions from Token Bridge that we hope we could find it in the interface, I leave the interface that we use here so you can consider adding those functions too:
`

function wormhole() external view returns (IWormhole);

function chainId() external view returns (uint16);

function isWrappedAsset(address token) external view returns (bool);

function transferTokens(address token, uint256 amount, uint16 recipientChain, bytes32 recipient, uint256 arbiterFee, uint32 nonce) external payable returns (uint64 sequence);

function wrapAndTransferETH(uint16 recipientChain, bytes32 recipient, uint256 arbiterFee, uint32 nonce) external payable returns (uint64 sequence);

function WETH() external view returns (IWETH);

function finality() external view returns (uint8);

`
If you have questions about the reason that we are using these extra functions I would be happy to answer and discuss.

@evan-gray
Copy link
Contributor

Hi Wormhole team, As a project that is built on top of Wormhole Core Bridge and Token Bridge, this PR is what we really needed! We were looking for an interface for Token Bridge and since there was no interface at the time, we created one. In our code we are using couple of more public functions from Token Bridge that we hope we could find it in the interface, I leave the interface that we use here so you can consider adding those functions too: `

function wormhole() external view returns (IWormhole);

function chainId() external view returns (uint16);

function isWrappedAsset(address token) external view returns (bool);

function transferTokens(address token, uint256 amount, uint16 recipientChain, bytes32 recipient, uint256 arbiterFee, uint32 nonce) external payable returns (uint64 sequence);

function wrapAndTransferETH(uint16 recipientChain, bytes32 recipient, uint256 arbiterFee, uint32 nonce) external payable returns (uint64 sequence);

function WETH() external view returns (IWETH);

function finality() external view returns (uint8);

` If you have questions about the reason that we are using these extra functions I would be happy to answer and discuss.

Thanks for this insight! Will leave a comment to ensure it gets added.

Copy link
Contributor

@evan-gray evan-gray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let’s review once more and ensure this is the cleanest interface and includes the latest updates like finality. My work on fast transfer needed the structs too, so making that easily available would likely be beneficial as well.

@gator-boi gator-boi closed this Oct 11, 2022
@gator-boi
Copy link
Contributor

Closing in favor of #1710

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants