feat: Implement internal Access API services #1932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
SanjayVas
force-pushed
the
sanjayvas-access-api-internal-impl
branch
from
1902d74 to
0e02126
Compare
SanjayVas
force-pushed
the
sanjayvas-access-api-db
branch
from
5cc9c81 to
a51beb5
Compare
SanjayVas
force-pushed
the
sanjayvas-access-api-internal-impl
branch
from
0e02126 to
a3256d6
Compare
SanjayVas
force-pushed
the
sanjayvas-access-api-db
branch
2 times, most recently
from
c688e62 to
8ae8c7d
Compare
SanjayVas
force-pushed
the
sanjayvas-access-api-internal-impl
branch
from
a3256d6 to
819f546
Compare
SanjayVas
force-pushed
the
sanjayvas-access-api-db
branch
from
8ae8c7d to
4624c54
Compare
SanjayVas
force-pushed
the
sanjayvas-access-api-internal-impl
branch
2 times, most recently
from
a593803 to
a6daa72
Compare
SanjayVas
force-pushed
the
sanjayvas-access-api-db
branch
from
4624c54 to
7ebb4bc
Compare
SanjayVas
force-pushed
the
sanjayvas-access-api-internal-impl
branch
from
a6daa72 to
98048db
Compare
SanjayVas
force-pushed
the
sanjayvas-access-api-db
branch
from
7ebb4bc to
c4a3f56
Compare
SanjayVas
force-pushed
the
sanjayvas-access-api-internal-impl
branch
from
98048db to
25e34e7
Compare
SanjayVas
force-pushed
the
sanjayvas-access-api-db
branch
from
c4a3f56 to
5778515
Compare
SanjayVas
force-pushed
the
sanjayvas-access-api-internal-impl
branch
from
25e34e7 to
5b918af
Compare
SanjayVas
force-pushed
the
sanjayvas-access-api-db
branch
2 times, most recently
from
32c4306 to
644cfcd
Compare
SanjayVas
force-pushed
the
sanjayvas-access-api-internal-impl
branch
from
5b918af to
ee2e12d
Compare
SanjayVas
force-pushed
the
sanjayvas-access-api-db
branch
from
644cfcd to
cc777ea
Compare
SanjayVas
force-pushed
the
sanjayvas-access-api-internal-impl
branch
2 times, most recently
from
9281a3a to
42d2ead
Compare
SanjayVas
force-pushed
the
sanjayvas-access-api-db
branch
from
cc777ea to
f8e7efa
Compare
SanjayVas
force-pushed
the
sanjayvas-access-api-internal-impl
branch
from
42d2ead to
15e53bf
Compare
SanjayVas
force-pushed
the
sanjayvas-access-api-db
branch
from
f8e7efa to
e394e7d
Compare
This was referenced Dec 4, 2024
SanjayVas
force-pushed
the
sanjayvas-access-api-internal-impl
branch
from
15e53bf to
c579af8
Compare
SanjayVas
force-pushed
the
sanjayvas-access-api-db
branch
2 times, most recently
from
9bf8694 to
bb9195b
Compare
SanjayVas
force-pushed
the
sanjayvas-access-api-internal-impl
branch
from
c579af8 to
4bd95d7
Compare
|
Depends on #1900. See design doc for more info, e.g. on how TLS clients are handled. |
stevenwarejones
approved these changes
Dec 6, 2024
There was a problem hiding this comment.
Reviewed 25 of 42 files at r1, 18 of 18 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @SanjayVas)
SanjayVas
force-pushed
the
sanjayvas-access-api-internal-impl
branch
from
4bd95d7 to
e576c9d
Compare
SanjayVas
force-pushed
the
sanjayvas-access-api-db
branch
2 times, most recently
from
e406690 to
f4b2821
Compare
SanjayVas
force-pushed
the
sanjayvas-access-api-internal-impl
branch
2 times, most recently
from
acfed3a to
981fb32
Compare
SanjayVas
force-pushed
the
sanjayvas-access-api-internal-impl
branch
from
981fb32 to
d8a94f8
Compare
SanjayVas
force-pushed
the
sanjayvas-access-api-internal-impl
branch
from
d8a94f8 to
f9f9e70
Compare
SanjayVas
commented
Dec 9, 2024
There was a problem hiding this comment.
Reviewed 1 of 2 files at r3.
Reviewable status:
SanjayVas
force-pushed
the
sanjayvas-access-api-internal-impl
branch
from
f9f9e70 to
4de6133
Compare
SanjayVas
commented
Dec 10, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r4.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.