-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add database schema for internal Access API #1900
Conversation
3846cbc
to
a90eeae
Compare
05b2993
to
970d09b
Compare
a90eeae
to
7f79b03
Compare
970d09b
to
89560af
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @SanjayVas)
src/main/resources/access/spanner/changelog.yaml
line 20 at r1 (raw file):
- include: file: create-access-schema.sql relativeToChangeLogFile: true
nit: missing new line
src/test/kotlin/org/wfanet/measurement/access/deploy/gcloud/spanner/AccessSchemaTest.kt
line 28 at r1 (raw file):
class AccessSchemaTest : UsingSpannerEmulator(Schemata.ACCESS_CHANGELOG_PATH) { @Test fun `database is created`() {}
Can you assert something or explain why it's not necessary to do so?
fd9d93d
to
8d089c3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @kungfucraig)
src/test/kotlin/org/wfanet/measurement/access/deploy/gcloud/spanner/AccessSchemaTest.kt
line 28 at r1 (raw file):
Previously, kungfucraig (Craig Wright) wrote…
Can you assert something or explain why it's not necessary to do so?
Done. Note that this follows the pattern of other schema tests in the repo.
8d089c3
to
46dd46f
Compare
89560af
to
5cc9c81
Compare
46dd46f
to
5d8150f
Compare
5cc9c81
to
a51beb5
Compare
5d8150f
to
9112779
Compare
c688e62
to
8ae8c7d
Compare
9112779
to
eaa50fd
Compare
8ae8c7d
to
4624c54
Compare
dc48051
to
4ed9472
Compare
4624c54
to
7ebb4bc
Compare
7ebb4bc
to
c4a3f56
Compare
455ea08
to
ffca3bc
Compare
c4a3f56
to
5778515
Compare
5778515
to
32c4306
Compare
ffca3bc
to
5aabc00
Compare
644cfcd
to
cc777ea
Compare
55f31e7
to
d595851
Compare
cc777ea
to
f8e7efa
Compare
ea0dff3
to
175c4e8
Compare
f8e7efa
to
e394e7d
Compare
175c4e8
to
a978119
Compare
e394e7d
to
9bf8694
Compare
141c856
to
a2008e1
Compare
9bf8694
to
bb9195b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 7 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @kungfucraig)
bb9195b
to
e406690
Compare
e406690
to
f4b2821
Compare
No description provided.