Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add database schema for internal Access API #1900

Merged
merged 1 commit into from
Dec 7, 2024

Conversation

SanjayVas
Copy link
Member

No description provided.

@wfa-reviewable
Copy link

This change is Reviewable

@SanjayVas SanjayVas force-pushed the sanjayvas-access-api branch from 3846cbc to a90eeae Compare November 5, 2024 17:15
@SanjayVas SanjayVas force-pushed the sanjayvas-access-api-db branch 2 times, most recently from 05b2993 to 970d09b Compare November 11, 2024 19:08
@SanjayVas SanjayVas force-pushed the sanjayvas-access-api branch from a90eeae to 7f79b03 Compare November 11, 2024 19:08
@SanjayVas SanjayVas force-pushed the sanjayvas-access-api-db branch from 970d09b to 89560af Compare November 11, 2024 23:39
@SanjayVas SanjayVas changed the base branch from sanjayvas-access-api to sanjayvas-access-api-internal November 11, 2024 23:40
Copy link
Member

@kungfucraig kungfucraig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @SanjayVas)


src/main/resources/access/spanner/changelog.yaml line 20 at r1 (raw file):

  - include:
      file: create-access-schema.sql
      relativeToChangeLogFile: true

nit: missing new line


src/test/kotlin/org/wfanet/measurement/access/deploy/gcloud/spanner/AccessSchemaTest.kt line 28 at r1 (raw file):

class AccessSchemaTest : UsingSpannerEmulator(Schemata.ACCESS_CHANGELOG_PATH) {

  @Test fun `database is created`() {}

Can you assert something or explain why it's not necessary to do so?

@SanjayVas SanjayVas force-pushed the sanjayvas-access-api-internal branch 3 times, most recently from fd9d93d to 8d089c3 Compare November 20, 2024 18:38
Copy link
Member Author

@SanjayVas SanjayVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @kungfucraig)


src/test/kotlin/org/wfanet/measurement/access/deploy/gcloud/spanner/AccessSchemaTest.kt line 28 at r1 (raw file):

Previously, kungfucraig (Craig Wright) wrote…

Can you assert something or explain why it's not necessary to do so?

Done. Note that this follows the pattern of other schema tests in the repo.

@SanjayVas SanjayVas force-pushed the sanjayvas-access-api-internal branch from 8d089c3 to 46dd46f Compare November 21, 2024 01:17
@SanjayVas SanjayVas force-pushed the sanjayvas-access-api-db branch from 89560af to 5cc9c81 Compare November 21, 2024 01:17
@SanjayVas SanjayVas force-pushed the sanjayvas-access-api-internal branch from 46dd46f to 5d8150f Compare November 21, 2024 20:18
@SanjayVas SanjayVas force-pushed the sanjayvas-access-api-db branch from 5cc9c81 to a51beb5 Compare November 21, 2024 20:18
@SanjayVas SanjayVas force-pushed the sanjayvas-access-api-internal branch from 5d8150f to 9112779 Compare November 25, 2024 19:35
@SanjayVas SanjayVas force-pushed the sanjayvas-access-api-db branch 2 times, most recently from c688e62 to 8ae8c7d Compare November 26, 2024 18:50
@SanjayVas SanjayVas force-pushed the sanjayvas-access-api-internal branch from 9112779 to eaa50fd Compare November 26, 2024 18:50
@SanjayVas SanjayVas force-pushed the sanjayvas-access-api-db branch from 8ae8c7d to 4624c54 Compare November 26, 2024 19:16
@SanjayVas SanjayVas force-pushed the sanjayvas-access-api-internal branch 2 times, most recently from dc48051 to 4ed9472 Compare November 26, 2024 19:18
@SanjayVas SanjayVas force-pushed the sanjayvas-access-api-db branch from 4624c54 to 7ebb4bc Compare November 26, 2024 19:18
Base automatically changed from sanjayvas-access-api-internal to main November 26, 2024 19:24
@SanjayVas SanjayVas force-pushed the sanjayvas-access-api-db branch from 7ebb4bc to c4a3f56 Compare November 27, 2024 19:25
@SanjayVas SanjayVas changed the base branch from main to sanjayvas-access-api November 27, 2024 19:26
@SanjayVas SanjayVas force-pushed the sanjayvas-access-api branch from 455ea08 to ffca3bc Compare November 27, 2024 21:37
@SanjayVas SanjayVas force-pushed the sanjayvas-access-api-db branch from c4a3f56 to 5778515 Compare November 27, 2024 21:37
@SanjayVas SanjayVas force-pushed the sanjayvas-access-api-db branch from 5778515 to 32c4306 Compare November 27, 2024 23:42
@SanjayVas SanjayVas force-pushed the sanjayvas-access-api branch from ffca3bc to 5aabc00 Compare November 27, 2024 23:42
Base automatically changed from sanjayvas-access-api to main November 28, 2024 06:41
@SanjayVas SanjayVas force-pushed the sanjayvas-access-api-db branch 2 times, most recently from 644cfcd to cc777ea Compare December 3, 2024 21:22
@SanjayVas SanjayVas changed the base branch from main to sanjayvas-access-api-impl December 3, 2024 21:25
@SanjayVas SanjayVas force-pushed the sanjayvas-access-api-impl branch from 55f31e7 to d595851 Compare December 4, 2024 00:32
@SanjayVas SanjayVas force-pushed the sanjayvas-access-api-db branch from cc777ea to f8e7efa Compare December 4, 2024 00:32
@SanjayVas SanjayVas changed the base branch from sanjayvas-access-api-impl to sanjayvas-access-api-internal-errors December 4, 2024 00:33
@SanjayVas SanjayVas force-pushed the sanjayvas-access-api-internal-errors branch from ea0dff3 to 175c4e8 Compare December 4, 2024 00:37
@SanjayVas SanjayVas force-pushed the sanjayvas-access-api-db branch from f8e7efa to e394e7d Compare December 4, 2024 00:42
@SanjayVas SanjayVas force-pushed the sanjayvas-access-api-internal-errors branch from 175c4e8 to a978119 Compare December 4, 2024 00:54
@SanjayVas SanjayVas force-pushed the sanjayvas-access-api-db branch from e394e7d to 9bf8694 Compare December 4, 2024 01:04
@SanjayVas SanjayVas force-pushed the sanjayvas-access-api-internal-errors branch 2 times, most recently from 141c856 to a2008e1 Compare December 5, 2024 00:56
Base automatically changed from sanjayvas-access-api-internal-errors to main December 5, 2024 01:08
@SanjayVas SanjayVas force-pushed the sanjayvas-access-api-db branch from 9bf8694 to bb9195b Compare December 5, 2024 19:47
@SanjayVas SanjayVas marked this pull request as ready for review December 6, 2024 00:56
Copy link
Collaborator

@stevenwarejones stevenwarejones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 7 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @kungfucraig)

@SanjayVas SanjayVas force-pushed the sanjayvas-access-api-db branch from bb9195b to e406690 Compare December 7, 2024 02:37
@SanjayVas SanjayVas force-pushed the sanjayvas-access-api-db branch from e406690 to f4b2821 Compare December 7, 2024 02:42
@SanjayVas SanjayVas enabled auto-merge (squash) December 7, 2024 02:45
@SanjayVas SanjayVas merged commit 08a2736 into main Dec 7, 2024
4 checks passed
@SanjayVas SanjayVas deleted the sanjayvas-access-api-db branch December 7, 2024 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants