fix: Ensure update-cmms workflow can run with ci Bazel configuration #1876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
SanjayVas
force-pushed
the
sanjayvas-buildbuddy-workflows
branch
from
85b7b01 to
0a7c00b
Compare
SanjayVas
force-pushed
the
sanjayvas-buildbuddy-workflows
branch
2 times, most recently
from
b433243 to
a985b89
Compare
SanjayVas
changed the title
SanjayVas
force-pushed
the
sanjayvas-buildbuddy-workflows
branch
from
a985b89 to
763d955
Compare
stevenwarejones
approved these changes
Oct 28, 2024
There was a problem hiding this comment.
Reviewed 15 of 15 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @SanjayVas)
This fixes BuildBuddy authentication issues in the update-cmms workflow.
SanjayVas
force-pushed
the
sanjayvas-buildbuddy-workflows
branch
from
763d955 to
43bee16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ciBazel configuration enables remote execution and caching via BuildBuddy. There was some missing configuration in #1840 which prevents theupdate-cmmsworkflow from completing successfully.